Bug 63679 - [Mac] Use system cursors instead of custom bitmaps where possible
Summary: [Mac] Use system cursors instead of custom bitmaps where possible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2011-06-29 18:35 PDT by Darin Adler
Modified: 2011-06-29 22:12 PDT (History)
3 users (show)

See Also:


Attachments
Patch (18.85 KB, patch)
2011-06-29 18:46 PDT, Darin Adler
no flags Details | Formatted Diff | Diff
Patch (19.82 KB, patch)
2011-06-29 21:54 PDT, Darin Adler
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2011-06-29 18:35:29 PDT
[Mac] Use system cursors instead of custom bitmaps where possible
Comment 1 Darin Adler 2011-06-29 18:46:26 PDT
Created attachment 99203 [details]
Patch
Comment 2 Darin Adler 2011-06-29 18:47:27 PDT
<rdar://problem/8269469>
Comment 3 WebKit Review Bot 2011-06-29 19:15:27 PDT
Comment on attachment 99203 [details]
Patch

Attachment 99203 [details] did not pass cr-mac-ews (chromium):
Output: http://queues.webkit.org/results/8959455
Comment 4 mitz 2011-06-29 19:23:05 PDT
Comment on attachment 99203 [details]
Patch

Looks good but apparently Chromium DumpRenderTree depends on the two files you’re removing.
Comment 5 Darin Adler 2011-06-29 21:34:41 PDT
It’s bizarre that Chromium’s DumpRenderTree uses these files! Maybe Chromium in general is making use of these for cursors?
Comment 6 Darin Adler 2011-06-29 21:54:05 PDT
Created attachment 99235 [details]
Patch
Comment 7 mitz 2011-06-29 22:01:33 PDT
Comment on attachment 99235 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99235&action=review

> Source/WebCore/ChangeLog:11
> +        WebCore/WebCore.gyp/WebCore.gyp: Removed the two now-unused PNG files.

Needs a leading star.
Comment 8 Darin Adler 2011-06-29 22:12:34 PDT
Committed r90087: <http://trac.webkit.org/changeset/90087>