Bug 63678 – More ScrollableArea scaffolding

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

More ScrollableArea scaffolding

[Anders Carlsson]

Created attachment 99198 [details]
Patch

[WebKit Review Bot]

Comment on attachment 99198 [details]
Patch

Attachment 99198 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8962275

[Sam Weinig]

Comment on attachment 99198 [details]
Patch

Fresh.  (/me is totally not reviewing this while on vacation.)  I think some other ports may have other classes that derive from ScrollView, so you will probably have to patch them too (or just add a default implementation to ScrollView.)

[Anders Carlsson]

Created attachment 99333 [details]
Patch

[WebKit Review Bot]

Comment on attachment 99333 [details]
Patch

Attachment 99333 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8962544

[Anders Carlsson]

Created attachment 99336 [details]
Patch

[Anders Carlsson]

Created attachment 99352 [details]
Patch

Comment on attachment 99352 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99352&action=review

> Source/WebCore/platform/ScrollableArea.cpp:208
> +bool ScrollableArea::isPinnedInDirectionOfScrollDelta(const IntSize& scrollDelta) const

You can drop “OfScrollDelta” from the name.

> Source/WebCore/platform/chromium/FramelessScrollView.cpp:62
> +    // FIXME

Can you elaborate?

> Source/WebCore/rendering/RenderLayer.cpp:797
> +    RenderObject* nextRenderer = renderer()->parent();
> +
> +    while (nextRenderer) {
> +        if (nextRenderer->isBox() && toRenderBox(nextRenderer)->canBeScrolledAndHasScrollableArea())
> +            return nextRenderer->enclosingLayer();
> +
> +        nextRenderer = nextRenderer->parent();
> +    }
> +
> +    return 0;

Looks like a for() loop.

> Source/WebCore/rendering/RenderLayer.cpp:2002
> +    // FIXME: We should return the frame view here (or possibly a parent frame view,

s/parent/ancestor/?

> Source/WebKit/chromium/src/WebScrollbarImpl.cpp:295
> +    // FIXME

More detail?

[Anders Carlsson]

Committed r90152: <http://trac.webkit.org/changeset/90152>