Bug 63661 - Make port/config.py mockable for easier unit testing
Summary: Make port/config.py mockable for easier unit testing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 63501
  Show dependency treegraph
 
Reported: 2011-06-29 14:40 PDT by Eric Seidel (no email)
Modified: 2011-06-29 14:59 PDT (History)
2 users (show)

See Also:


Attachments
Patch (7.89 KB, patch)
2011-06-29 14:42 PDT, Eric Seidel (no email)
abarth: review+
eric: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2011-06-29 14:40:13 PDT
Make port/config.py mockable for easier unit testing
Comment 1 Eric Seidel (no email) 2011-06-29 14:42:12 PDT
Created attachment 99154 [details]
Patch
Comment 2 Adam Barth 2011-06-29 14:45:37 PDT
Comment on attachment 99154 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99154&action=review

> Tools/Scripts/webkitpy/common/system/filesystem.py:62
> +        import sys

Why not import sys at the top of the file?
Comment 3 Eric Seidel (no email) 2011-06-29 14:46:09 PDT
Comment on attachment 99154 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99154&action=review

>> Tools/Scripts/webkitpy/common/system/filesystem.py:62
>> +        import sys
> 
> Why not import sys at the top of the file?

Sure, happy to move it.
Comment 4 Eric Seidel (no email) 2011-06-29 14:49:25 PDT
Sigh.  This landed as http://trac.webkit.org/changeset/90050.  Silly git.
Comment 5 Dirk Pranke 2011-06-29 14:50:27 PDT
Looks fine to me also ...
Comment 6 Eric Seidel (no email) 2011-06-29 14:51:00 PDT
(In reply to comment #5)
> Looks fine to me also ...

Thanks for looking!
Comment 7 Eric Seidel (no email) 2011-06-29 14:59:45 PDT
Fixed in http://trac.webkit.org/changeset/90051.