Bug 63657 - Remove ElementWithPseudoId, since now an Element can store it all by itself.
Summary: Remove ElementWithPseudoId, since now an Element can store it all by itself.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Dimitri Glazkov (Google)
URL:
Keywords:
Depends on:
Blocks: 58584
  Show dependency tree / graph
 
Reported: 2011-06-29 14:16 PDT by Dimitri Glazkov (Google)
Modified: 2011-06-30 13:45 PDT (History)
5 users (show)

See Also:

Attachments
Patch (19.19 KB, patch)
2011-06-29 14:18 PDT, Dimitri Glazkov (Google) 		no flags Details | Formatted Diff | Diff
Patch for landing (19.21 KB, patch)
2011-06-29 16:23 PDT, Dimitri Glazkov (Google) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dimitri Glazkov (Google) 2011-06-29 14:16:36 PDT 
Remove ElementWithPseudoId, since now an Element can store it all by itself.
Comment 1 Dimitri Glazkov (Google) 2011-06-29 14:18:09 PDT 
Created attachment 99148 [details]
Patch
Comment 2 Kent Tamura 2011-06-29 14:55:06 PDT 
Comment on attachment 99148 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99148&action=review

> Source/WebCore/html/ValidationMessage.cpp:135
>      host->ensureShadowRoot()->appendChild(m_bubble.get(), ec);
>  

nit: We had better have ASSERT(!ec);
Comment 3 Dimitri Glazkov (Google) 2011-06-29 16:23:04 PDT 
Created attachment 99176 [details]
Patch for landing
Comment 4 WebKit Review Bot 2011-06-29 17:03:49 PDT 
Comment on attachment 99176 [details]
Patch for landing

Clearing flags on attachment: 99176

Committed r90071: <http://trac.webkit.org/changeset/90071>
Comment 5 WebKit Review Bot 2011-06-29 17:03:54 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Rafael Brandao 2011-06-30 13:35:11 PDT 
Got this when I was building:

Reading [...]/WebKit/Source/WebCore/WebCore.pro [[...]/WebKit/WebKitBuild/Release/WebCore]
WARNING: Failure to find: html/shadow/ElementWithPseudoId.h

Perhaps this patch caused this? It's building though, just an annoying warning.
Comment 7 Rafael Brandao 2011-06-30 13:45:59 PDT 
(In reply to comment #6)
> Got this when I was building:
> 
> Reading [...]/WebKit/Source/WebCore/WebCore.pro [[...]/WebKit/WebKitBuild/Release/WebCore]
> WARNING: Failure to find: html/shadow/ElementWithPseudoId.h
> 
> Perhaps this patch caused this? It's building though, just an annoying warning.

It'll be a quick fix, I'll handle that.