Bug 63655 - Switch computeWidth and computeHeight functions to new layout types
Summary: Switch computeWidth and computeHeight functions to new layout types
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Levi Weintraub
URL:
Keywords:
Depends on:
Blocks: 63567
  Show dependency tree / graph
 
Reported: 2011-06-29 14:07 PDT by Levi Weintraub
Modified: 2011-06-29 17:00 PDT (History)
3 users (show)

See Also:

Attachments
Patch (47.67 KB, patch)
2011-06-29 14:51 PDT, Levi Weintraub 		no flags Details | Formatted Diff | Diff
Patch for landing (47.26 KB, patch)
2011-06-29 16:17 PDT, Levi Weintraub 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Levi Weintraub 2011-06-29 14:07:02 PDT 
More conversion fun!
Comment 1 Levi Weintraub 2011-06-29 14:51:29 PDT 
Created attachment 99155 [details]
Patch
Comment 2 Eric Seidel (no email) 2011-06-29 14:59:25 PDT 
Comment on attachment 99155 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99155&action=review

> Source/WebCore/rendering/LayoutTypes.h:44
> +#define LAYOUT_MAX INT_MAX

I guess we could use numeric_limits<LayoutUnit>::max() in the callsites.  I'm not sure that's any better though.
Comment 3 Levi Weintraub 2011-06-29 15:01:27 PDT 
(In reply to comment #2)
> (From update of attachment 99155 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=99155&action=review
> 
> > Source/WebCore/rendering/LayoutTypes.h:44
> > +#define LAYOUT_MAX INT_MAX
> 
> I guess we could use numeric_limits<LayoutUnit>::max() in the callsites.  I'm not sure that's any better though.

I like that way more actually. I'll change it before landing.
Comment 4 Darin Adler 2011-06-29 15:16:38 PDT 
Comment on attachment 99155 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99155&action=review

>>> Source/WebCore/rendering/LayoutTypes.h:44
>>> +#define LAYOUT_MAX INT_MAX
>> 
>> I guess we could use numeric_limits<LayoutUnit>::max() in the callsites.  I'm not sure that's any better though.
> 
> I like that way more actually. I'll change it before landing.

Good. I think it’s much better!
Comment 5 Levi Weintraub 2011-06-29 16:17:14 PDT 
Created attachment 99173 [details]
Patch for landing
Comment 6 WebKit Review Bot 2011-06-29 17:00:02 PDT 
Comment on attachment 99173 [details]
Patch for landing

Clearing flags on attachment: 99173

Committed r90069: <http://trac.webkit.org/changeset/90069>
Comment 7 WebKit Review Bot 2011-06-29 17:00:07 PDT 
All reviewed patches have been landed.  Closing bug.