Bug 63641 - Convert uses of computeLengthIntForLength to computeLength<Length>()
Summary: Convert uses of computeLengthIntForLength to computeLength<Length>()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Luke Macpherson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-29 12:02 PDT by Luke Macpherson
Modified: 2011-06-29 14:26 PDT (History)
1 user (show)

See Also:

Attachments
Patch (7.66 KB, patch)
2011-06-29 12:04 PDT, Luke Macpherson 		no flags Details | Formatted Diff | Diff
Patch (7.66 KB, patch)
2011-06-29 13:30 PDT, Luke Macpherson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Luke Macpherson 2011-06-29 12:02:25 PDT 
Convert uses of computeLengthIntForLength to computeLength<Length>()
Comment 1 Luke Macpherson 2011-06-29 12:04:24 PDT 
Created attachment 99122 [details]
Patch
Comment 2 Darin Adler 2011-06-29 12:08:44 PDT 
Comment on attachment 99122 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99122&action=review

> Source/WebCore/css/CSSStyleSelector.cpp:4054
> +            lineHeight = primitiveValue->computeLength<Length>(style(), m_rootElementStyle,  multiplier);

Extra space here after one of the commas.
Comment 3 Luke Macpherson 2011-06-29 13:30:16 PDT 
Created attachment 99138 [details]
Patch
Comment 4 WebKit Review Bot 2011-06-29 14:26:14 PDT 
Comment on attachment 99138 [details]
Patch

Clearing flags on attachment: 99138

Committed r90045: <http://trac.webkit.org/changeset/90045>
Comment 5 WebKit Review Bot 2011-06-29 14:26:18 PDT 
All reviewed patches have been landed.  Closing bug.