Bug 63612 - implement WebEditorClient::setInputMethodState()
Summary: implement WebEditorClient::setInputMethodState()
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-29 01:55 PDT by SangYong Park
Modified: 2014-03-24 01:38 PDT (History)
1 user (show)

See Also:

Attachments
patch (5.87 KB, patch)
2011-06-29 03:04 PDT, SangYong Park 		morrita: review-
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description SangYong Park 2011-06-29 01:55:13 PDT 
implement WebEditorClient::setInputMethodState()
Comment 1 SangYong Park 2011-06-29 03:04:45 PDT 
Created attachment 99062 [details]
patch
Comment 2 Early Warning System Bot 2011-06-29 03:13:00 PDT 
Comment on attachment 99062 [details]
patch

Attachment 99062 [details] did not pass qt-ews (qt):
Output: http://queues.webkit.org/results/8963030
Comment 3 Alexey Proskuryakov 2011-06-29 10:27:22 PDT 
Is it really necessary? I hoped that we could get rid of it in WebKit2.
Comment 4 Hajime Morrita 2011-07-04 23:55:22 PDT 
Comment on attachment 99062 [details]
patch

r- per the ews error.
It looks that Qt WK1 depends on this. so Qt WK2 might.
Comment 5 Alexey Proskuryakov 2011-07-05 00:02:49 PDT 
That's not a good reason for Qt WebKit2 to depend on it. Other ports have the same logic, but implemented without relying on this client call.