Bug 63593 - IndexedDB: Prepare for running layout tests with LevelDB
Summary: IndexedDB: Prepare for running layout tests with LevelDB
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Hans Wennborg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-28 18:20 PDT by Hans Wennborg
Modified: 2011-06-30 11:33 PDT (History)
2 users (show)

See Also:


Attachments
Patch (11.41 KB, patch)
2011-06-28 18:26 PDT, Hans Wennborg
tony: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hans Wennborg 2011-06-28 18:20:52 PDT
IndexedDB: Prepare for running layout tests with LevelDB
Comment 1 Hans Wennborg 2011-06-28 18:26:14 PDT
Created attachment 99021 [details]
Patch
Comment 2 David Grogan 2011-06-29 15:26:27 PDT
Comment on attachment 99021 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99021&action=review

LGTM

> Source/WebCore/ChangeLog:8
> +        Migration of data from SQLite to LevelDB must be done before the

From an IM convo with hans:
the problem occurs when we first use leveldb, then sqlite, and then leveldb again.. which happens in the case of layout tests
Comment 3 Tony Chang 2011-06-30 11:06:14 PDT
Comment on attachment 99021 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=99021&action=review

>> Source/WebCore/ChangeLog:8
>> +        Migration of data from SQLite to LevelDB must be done before the
> 
> From an IM convo with hans:
> the problem occurs when we first use leveldb, then sqlite, and then leveldb again.. which happens in the case of layout tests

Would be nice to include this in the ChangeLog description.

> Source/WebCore/storage/IDBFactoryBackendImpl.cpp:110
> +            (void)migrationSucceeded; // FIXME: When migration is actually implemented, we need error handling here.

Nit: UNUSED_PARAM(migrationSucceeded)
Comment 4 Hans Wennborg 2011-06-30 11:33:11 PDT
Committed r90137: <http://trac.webkit.org/changeset/90137>