Bug 63587 - Consolidate the fast/loader and fast/loading directories
Summary: Consolidate the fast/loader and fast/loading directories
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-28 17:18 PDT by Darin Adler
Modified: 2011-06-29 08:34 PDT (History)
3 users (show)

See Also:


Attachments
Patch (7.05 KB, patch)
2011-06-28 17:27 PDT, Darin Adler
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-01 (1.34 MB, application/zip)
2011-06-28 17:48 PDT, WebKit Review Bot
no flags Details
Patch for landing (8.24 KB, patch)
2011-06-28 22:32 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2011-06-28 17:18:29 PDT
Consolidate the fast/loader and fast/loading directories
Comment 1 Darin Adler 2011-06-28 17:27:54 PDT
Created attachment 99006 [details]
Patch
Comment 2 WebKit Review Bot 2011-06-28 17:48:44 PDT
Comment on attachment 99006 [details]
Patch

Attachment 99006 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8948974

New failing tests:
fast/loader/subframe-removes-itself.html
Comment 3 WebKit Review Bot 2011-06-28 17:48:49 PDT
Created attachment 99011 [details]
Archive of layout-test-results from ec2-cr-linux-01

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-01  Port: Chromium  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 4 Darin Adler 2011-06-28 17:51:50 PDT
Maybe I did not spot the changes needed for Chromium test expectations? Could someone with some Chromium expertise help me out with this?
Comment 5 Adam Barth 2011-06-28 17:58:15 PDT
> Could someone with some Chromium expertise help me out with this?

Sure.
Comment 6 Adam Barth 2011-06-28 18:12:33 PDT
Comment on attachment 99006 [details]
Patch

I didn't see anything obvious, but I'll figure it out and land this patch for you.
Comment 7 Adam Barth 2011-06-28 22:31:42 PDT
The moved test would have failed on all platforms.  The old directory apparently used to trigger an implicit call to dumpFrameLoadCallbacks.  I've added an explicit call to preserve the intent of the test.
Comment 8 Adam Barth 2011-06-28 22:32:36 PDT
Created attachment 99040 [details]
Patch for landing
Comment 9 WebKit Review Bot 2011-06-29 00:12:02 PDT
Comment on attachment 99040 [details]
Patch for landing

Clearing flags on attachment: 99040

Committed r89994: <http://trac.webkit.org/changeset/89994>
Comment 10 WebKit Review Bot 2011-06-29 00:12:10 PDT
All reviewed patches have been landed.  Closing bug.
Comment 11 Darin Adler 2011-06-29 08:13:28 PDT
(In reply to comment #7)
> The moved test would have failed on all platforms.

Oh, got it. How could I have missed that?!

Thanks very much for taking care of this.
Comment 12 Adam Barth 2011-06-29 08:34:11 PDT
My pleasure.