Bug 63563 – DFG JIT - add support for double arith to speculative path

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Gavin Barraclough]

Add integer support for div & mod, add double support for div, mod, add, sub & mul, dynamically selecting based on operand types.

[Gavin Barraclough]

Created attachment 98970 [details]
The patch

[WebKit Review Bot]

Attachment 98970 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:187:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Oliver Hunt]

Comment on attachment 98970 [details]
The patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98970&action=review

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:196
> +            } else if (isDoubleConstant(nodeIndex)) {

Fiux these style issues

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:204
> +                return fpr;

again

[Gavin Barraclough]

Fixed in r89961.