Bug 63563 - DFG JIT - add support for double arith to speculative path
Summary: DFG JIT - add support for double arith to speculative path
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-28 14:15 PDT by Gavin Barraclough
Modified: 2011-06-28 14:33 PDT (History)
1 user (show)

See Also:


Attachments
The patch (19.43 KB, patch)
2011-06-28 14:17 PDT, Gavin Barraclough
oliver: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2011-06-28 14:15:09 PDT
Add integer support for div & mod, add double support for div, mod, add, sub & mul, dynamically selecting based on operand types.
Comment 1 Gavin Barraclough 2011-06-28 14:17:14 PDT
Created attachment 98970 [details]
The patch
Comment 2 WebKit Review Bot 2011-06-28 14:20:52 PDT
Attachment 98970 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1

Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:187:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Oliver Hunt 2011-06-28 14:24:03 PDT
Comment on attachment 98970 [details]
The patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98970&action=review

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:196
> +            } else if (isDoubleConstant(nodeIndex)) {

Fiux these style issues

> Source/JavaScriptCore/dfg/DFGSpeculativeJIT.cpp:204
> +                return fpr;

again
Comment 4 Gavin Barraclough 2011-06-28 14:33:51 PDT
Fixed in r89961.