Bug 63536 - [Chromium] DRT: Add setHixie76WebSocketProtocolEnabled to LayoutTestController
Summary: [Chromium] DRT: Add setHixie76WebSocketProtocolEnabled to LayoutTestController
Status: RESOLVED DUPLICATE of bug 63532
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Yuta Kitamura
URL:
Keywords:
Depends on:
Blocks: 50099
  Show dependency tree / graph
 
Reported: 2011-06-28 07:23 PDT by Yuta Kitamura
Modified: 2011-06-29 01:04 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.92 KB, patch)
2011-06-28 07:28 PDT, Yuta Kitamura 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yuta Kitamura 2011-06-28 07:23:20 PDT 
Add setHixie76WebSocketProtocolEnabled() method to LayoutTestController in order to switch WebSocket protocols in layout tests.

Win/Mac implementation: bug 63532
Comment 1 Yuta Kitamura 2011-06-28 07:28:09 PDT 
Created attachment 98916 [details]
Patch
Comment 2 Kent Tamura 2011-06-28 07:42:55 PDT 
Comment on attachment 98916 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98916&action=review

> Tools/ChangeLog:8
> +        Add a method to LayoutTestController so we can switch WebSocket protocols in layout tests.

Why don't you use window.internals?
See WebCore/testing/Internals.*
Comment 3 Yuta Kitamura 2011-06-28 23:49:32 PDT 
Comment on attachment 98916 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98916&action=review

Taking Adam's advice, I would like to use LayoutTestController::overridePreference(), rather than adding a new method to LayoutTestController. I'm preparing a new patch.

>> Tools/ChangeLog:8
>> +        Add a method to LayoutTestController so we can switch WebSocket protocols in layout tests.
> 
> Why don't you use window.internals?
> See WebCore/testing/Internals.*

I don't think I can use window.internals for this purpose, because we need to reset preference values for each test run to prevent preference values from previous runs from leaking to the following tests.
Comment 4 Yuta Kitamura 2011-06-29 01:04:24 PDT 
I will do Chromium part in bug 63532.

*** This bug has been marked as a duplicate of bug 63532 ***