Bug 63520 – [X11][WK2] X error with plugin tests

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Balazs Kelemen]

plugins/destroy-stream-twice.html and plugins/npruntime/npruntime.html take out the following error:
The program '<unknown>' received an X Window System error.
This probably reflects a bug in the program.
The error was 'BadValue (integer parameter out of range for operation)'.
  (Details: serial 208 error_code 2 request_code 53 minor_code 0)
  (Note to programmers: normally, X errors are reported asynchronously;
   that is, you will receive the error a while after causing it.
   To debug your program, run it with the --sync command line
   option to change this behavior. You can then get a meaningful
   backtrace from your debugger if you break on the gdk_x_error() function.)

Both of them has an embed tag with width:0 and height:0 attributes. It came out that the X server does not accept a pixmap with (0,0) dimensions so we need to handle this as a special case.

[Balazs Kelemen]

plugins/object-embed-plugin-scripting.html is also affected.

[Balazs Kelemen]

Created attachment 98886 [details]
Patch

[Kenneth Rohde Christiansen]

Comment on attachment 98886 [details]
Patch

Nice!

[WebKit Review Bot]

Comment on attachment 98886 [details]
Patch

Clearing flags on attachment: 98886

Committed r89921: <http://trac.webkit.org/changeset/89921>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.