Bug 63514 - Fix filesystem_unittest.FileSystemTest test_read_and_write_file()
Summary: Fix filesystem_unittest.FileSystemTest test_read_and_write_file()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Roland Steiner
URL:
Keywords:
Depends on:
Blocks: 61772 63419 63528
  Show dependency tree / graph
 
Reported: 2011-06-28 00:02 PDT by Roland Steiner
Modified: 2011-06-28 11:29 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.87 KB, patch)
2011-06-28 00:06 PDT, Roland Steiner 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roland Steiner 2011-06-28 00:02:44 PDT 
test_read_and_write_file in the FileSystemTest unit test has 3 bugs:

.) any raised exception from assertEquals is swallowed by the 'except' clause
.) text/binary_path is not 'None' after mktemp, but os.remove may still raise an exception if no data was actually written to the file
.) write_text_file is used instead of write_binary_file to write binary contents (this again was swallowed by 'except')
Comment 1 Roland Steiner 2011-06-28 00:06:32 PDT 
Created attachment 98868 [details]
Patch
Comment 2 WebKit Review Bot 2011-06-28 11:29:30 PDT 
Comment on attachment 98868 [details]
Patch

Clearing flags on attachment: 98868

Committed r89944: <http://trac.webkit.org/changeset/89944>
Comment 3 WebKit Review Bot 2011-06-28 11:29:34 PDT 
All reviewed patches have been landed.  Closing bug.