Bug 63511 - Use RefPtr for the HTMLElement data members of TextFieldInptType and SearchInputType
Summary: Use RefPtr for the HTMLElement data members of TextFieldInptType and SearchIn...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Forms (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks: 61415
  Show dependency tree / graph
 
Reported: 2011-06-27 23:07 PDT by Kent Tamura
Modified: 2011-06-28 02:21 PDT (History)
3 users (show)

See Also:

Attachments
Patch (12.48 KB, patch)
2011-06-27 23:33 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
Patch (12.67 KB, patch)
2011-06-28 00:43 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2011-06-27 23:07:22 PDT 
Use RefPtr for the HTMLElement data members of TextFieldInptType and SearchInputType
Comment 1 Kent Tamura 2011-06-27 23:33:47 PDT 
Created attachment 98865 [details]
Patch
Comment 2 Kent Tamura 2011-06-28 00:43:15 PDT 
Created attachment 98874 [details]
Patch
Comment 3 Hajime Morrita 2011-06-28 01:15:27 PDT 
Comment on attachment 98874 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98874&action=review

> Source/WebCore/html/TextFieldInputType.cpp:139
> +    bool shouldHaveSpinButton = theme->shouldHaveSpinButton(element());

Why do we need this change?
Comment 4 Kent Tamura 2011-06-28 01:18:14 PDT 
Comment on attachment 98874 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98874&action=review

Thank you for reviewing.

>> Source/WebCore/html/TextFieldInputType.cpp:139
>> +    bool shouldHaveSpinButton = theme->shouldHaveSpinButton(element());
> 
> Why do we need this change?

RenderTheme::themeForPage() might create a new RenderTheme.
Comment 5 Hajime Morrita 2011-06-28 01:45:05 PDT 
> RenderTheme::themeForPage() might create a new RenderTheme.
Got it. Thank you for the explanation!
Comment 6 WebKit Review Bot 2011-06-28 02:21:12 PDT 
Comment on attachment 98874 [details]
Patch

Clearing flags on attachment: 98874

Committed r89910: <http://trac.webkit.org/changeset/89910>
Comment 7 WebKit Review Bot 2011-06-28 02:21:18 PDT 
All reviewed patches have been landed.  Closing bug.