Bug 63507 - webarchive/loading/missing-data.html is failing on Mac
Summary: webarchive/loading/missing-data.html is failing on Mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-27 20:34 PDT by Ryosuke Niwa
Modified: 2011-08-03 14:53 PDT (History)
5 users (show)

See Also:


Attachments
Patch (1.55 KB, patch)
2011-08-03 14:49 PDT, Anders Carlsson
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2011-06-27 20:34:16 PDT
webarchive/loading/missing-data.html has been failing since
http://trac.webkit.org/log/trunk?action=stop_on_copy&mode=stop_on_copy&rev=89742&stop_rev=89736&limit=100&verbose=on

according to http://build.webkit.org/TestFailures/#/Leopard Intel Release (Tests)
Comment 1 Ryosuke Niwa 2011-06-27 20:34:41 PDT
The test was added by http://trac.webkit.org/changeset/66562.
Comment 2 Ryosuke Niwa 2011-06-27 20:37:10 PDT
Looking at SnowLeopard Intel Leak's failures, it seems like this test was affected by other tests being added to the skipped list:
http://trac.webkit.org/log/trunk?action=stop_on_copy&mode=stop_on_copy&rev=89736&stop_rev=89733&limit=100&verbose=on
Comment 3 Adam Roben (:aroben) 2011-07-01 12:28:03 PDT
So what's the right thing to do here? I guess we could try skipping this test, too.
Comment 5 Adam Roben (:aroben) 2011-07-01 12:30:48 PDT
(In reply to comment #4)
> Looks like it's only intermittently failing on Leopard:
> 
> http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r90229%20(33702)/results.html failed
> http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r90228%20(33701)/results.html passed
> http://build.webkit.org/results/Leopard%20Intel%20Release%20(Tests)/r90226%20(33700)/results.html failed

Oh, I'm wrong. Build 33701 didn't complete, but presumably the test would have failed. (I need to teach TestFailures not to get confused by that.)
Comment 6 Anders Carlsson 2011-08-03 14:49:07 PDT
Created attachment 102832 [details]
Patch
Comment 7 Adam Barth 2011-08-03 14:50:50 PDT
Comment on attachment 102832 [details]
Patch

Sorry for breaking this.  Moving web archives into documentloader makes infinitely more sense than dealing with them in FrameLoader.
Comment 8 Anders Carlsson 2011-08-03 14:53:21 PDT
Committed r92314: <http://trac.webkit.org/changeset/92314>