RESOLVED FIXED 63503
[Chromium] Pass an optional WebNode that is the node receiving the context menu action. 
https://bugs.webkit.org/show_bug.cgi?id=63503
Summary [Chromium] Pass an optional WebNode that is the node receiving the context me...
James Hawkins
Reported 2011-06-27 19:01:59 PDT
[Chromium] Pass an optional WebNode that is the node receiving the context menu action.
Attachments
Patch (5.07 KB, patch)
2011-06-27 19:02 PDT, James Hawkins 		fishd: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
James Hawkins
Comment 1 2011-06-27 19:02:36 PDT
Created attachment 98843 [details] Patch
James Hawkins
Comment 2 2011-06-27 19:05:17 PDT
+Darin
Darin Fisher (:fishd, Google)
Comment 3 2011-06-27 22:08:00 PDT
Comment on attachment 98843 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98843&action=review OK, R=me > Source/WebKit/chromium/src/WebFrameImpl.cpp:1138 > + pluginContainer = pluginContainerFromNode(node); nit: indentation
James Hawkins
Comment 4 2011-06-28 09:57:05 PDT
(In reply to comment #3) > (From update of attachment 98843 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=98843&action=review > > OK, R=me > > > Source/WebKit/chromium/src/WebFrameImpl.cpp:1138 > > + pluginContainer = pluginContainerFromNode(node); > > nit: indentation Done.
James Hawkins
Comment 5 2011-06-28 09:58:12 PDT
Committed r89939: <http://trac.webkit.org/changeset/89939>
Pavel Feldman
Comment 6 2011-06-29 07:23:38 PDT
Comment on attachment 98843 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98843&action=review > Source/WebKit/chromium/src/WebFrameImpl.cpp:291 > + if (coreNode->hasTagName(HTMLNames::objectTag) || coreNode->hasTagName(HTMLNames::embedTag)) { This call fails with coreNode == 0 in the "Copy" branch.
Note You need to log in before you can comment on or make changes to this bug.