Bug 63496 - [Qt] DRT support for setInteractiveFormValidationEnabled
Summary: [Qt] DRT support for setInteractiveFormValidationEnabled
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Diego Gonzalez
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2011-06-27 17:16 PDT by Diego Gonzalez
Modified: 2011-06-29 05:32 PDT (History)
2 users (show)

See Also:

Attachments
Patch (6.23 KB, patch)
2011-06-27 17:20 PDT, Diego Gonzalez 		kenneth: review+
kenneth: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Gonzalez 2011-06-27 17:16:46 PDT 
Make possible to enable setInteractiveFormValidationEnabled on Qt DRT

Unskipped:
    fast/forms/interactive-validation-prevented.html
    fast/forms/interactive-validation-attach-assertion.html
    fast/forms/interactive-validation-assertion-by-validate-twice.html
    fast/forms/interactive-validation-select-crash.html
    fast/forms/interactive-validation-crash-by-style-override.html
Comment 1 Diego Gonzalez 2011-06-27 17:20:46 PDT 
Created attachment 98821 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2011-06-28 01:43:54 PDT 
Comment on attachment 98821 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98821&action=review

> Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:1012
> +void DumpRenderTreeSupportQt::setInteractiveFormValidationEnabled(QWebPage* page, bool flag)

flag is a pretty bad name for a bool. what about 'bool enable'
Comment 3 Diego Gonzalez 2011-06-29 05:32:29 PDT 
commited at r89972