Bug 63489 – [Qt] DRT: Provide LayoutTestController::setDefersLoading and ::goBack support

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Diego Gonzalez]

Provide support for LayoutTestController::setDefersLoading and ::goBack

LayoutTest:
    loader/navigation-while-deferring-loads.html

[Diego Gonzalez]

Created attachment 98807 [details]
Patch

[Antonio Gomes]

Comment on attachment 98807 [details]
Patch

Diego, do we need to reset the defersLoading flag per-test run?

[Diego Gonzalez]

According my local tests is not necessary to reset the flag.

(In reply to comment #2)
> (From update of attachment 98807 [details])
> Diego, do we need to reset the defersLoading flag per-test run?

[Diego Gonzalez]

Created attachment 99091 [details]
Patch v2

[Antonio Gomes]

Comment on attachment 99091 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=99091&action=review

> Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:1005
> +void DumpRenderTreeSupportQt::goBack(QWebPage* page)
> +{
> +    Page* corePage = QWebPagePrivate::core(page);
> +    if (corePage)
> +        corePage->goBack();
> +}

How is it different from window.history.back(), diego?

http://www.w3schools.com/jsref/met_his_back.asp

[Diego Gonzalez]

(In reply to comment #5)
> (From update of attachment 99091 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=99091&action=review
> 
> > Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:1005
> > +void DumpRenderTreeSupportQt::goBack(QWebPage* page)
> > +{
> > +    Page* corePage = QWebPagePrivate::core(page);
> > +    if (corePage)
> > +        corePage->goBack();
> > +}
> 
> How is it different from window.history.back(), diego?
> 
> http://www.w3schools.com/jsref/met_his_back.asp

bool Page::goBack()
{
    HistoryItem* item = backForward()->backItem();
    
    if (item) {
        goToItem(item, FrameLoadTypeBack);
        return true;
    }
    return false;
}

It seems the sameway

[Antonio Gomes]

Could we check why it was added in a follow up, diego?

And why it is needed?

[Antonio Gomes]

Comment on attachment 99091 [details]
Patch v2

View in context: https://bugs.webkit.org/attachment.cgi?id=99091&action=review

>>> Source/WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp:1005
>>> +void DumpRenderTreeSupportQt::goBack(QWebPage* page)
>>> +{
>>> +    Page* corePage = QWebPagePrivate::core(page);
>>> +    if (corePage)
>>> +        corePage->goBack();
>>> +}
>> 
>> How is it different from window.history.back(), diego?
>> 
>> http://www.w3schools.com/jsref/met_his_back.asp
> 
> bool Page::goBack()
> {
>     HistoryItem* item = backForward()->backItem();
> 
>     if (item) {
>         goToItem(item, FrameLoadTypeBack);
>         return true;
>     }
>     return false;
> }
> 
> It seems the sameway

How is it different from window.history.back(), diego?

http://www.w3schools.com/jsref/met_his_back.asp

[Diego Gonzalez]

Commited at r90178