Bug 63487 - Web process always pauses on launch
Summary: Web process always pauses on launch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Jeff Miller
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-27 15:01 PDT by Jeff Miller
Modified: 2011-06-28 07:46 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.78 KB, patch)
2011-06-27 15:03 PDT, Jeff Miller 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jeff Miller 2011-06-27 15:01:35 PDT 
The fix for bug 63335 in r89865 regressed the logic used to pause the web process. The web process now always pauses on launch when the the shift and alt keys were not held down, which means it almost always pauses.
Comment 1 Jeff Miller 2011-06-27 15:03:24 PDT 
Created attachment 98795 [details]
Patch
Comment 2 WebKit Review Bot 2011-06-27 15:07:22 PDT 
Attachment 98795 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1

Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Jeff Miller 2011-06-27 15:08:30 PDT 
(In reply to comment #2)
> Attachment 98795 [details] did not pass style-queue:
> 
> Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
> 
> Source/WebKit2/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
> Total errors found: 1 in 2 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

Whoops, I'll add the bug number before landing.
Comment 4 Jeff Miller 2011-06-27 15:12:33 PDT 
Committed r89865: <http://trac.webkit.org/changeset/89865>
Comment 5 Jon Honeycutt 2011-06-27 17:35:34 PDT 
This regressed in <http://trac.webkit.org/changeset/89685>, not <http://trac.webkit.org/changeset/89865>. That's where this was fixed!
Comment 6 Adam Roben (:aroben) 2011-06-28 07:46:38 PDT 
Comment on attachment 98795 [details]
Patch

Thanks for fixing this!