WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
63486
Fix filesystem-no-callback-null-ptr-crash.html test to reference proper file api methods
https://bugs.webkit.org/show_bug.cgi?id=63486
Summary
Fix filesystem-no-callback-null-ptr-crash.html test to reference proper file ...
Adam Klein
Reported
2011-06-27 15:01:07 PDT
Fix filesystem-no-callback-null-ptr-crash.html test to reference proper file api methods
Attachments
Patch
(1.63 KB, patch)
2011-06-27 15:01 PDT
,
Adam Klein
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Klein
Comment 1
2011-06-27 15:01:28 PDT
Created
attachment 98794
[details]
Patch
Adam Klein
Comment 2
2011-06-27 15:03:42 PDT
This test was correct when written, but the names of these methods has since changed. However, that wasn't being noticed because they're wrapped in "try {} catch(e) {}".
WebKit Review Bot
Comment 3
2011-06-27 15:31:49 PDT
Comment on
attachment 98794
[details]
Patch Clearing flags on attachment: 98794 Committed
r89870
: <
http://trac.webkit.org/changeset/89870
>
WebKit Review Bot
Comment 4
2011-06-27 15:31:53 PDT
All reviewed patches have been landed. Closing bug.
Kinuko Yasuda
Comment 5
2011-06-28 02:15:52 PDT
Thanks a lot Adam for fixing this!!
Adam Klein
Comment 6
2011-06-28 10:40:07 PDT
(In reply to
comment #5
)
> Thanks a lot Adam for fixing this!!
No problem. However, it still doesn't explain the flakiness in
http://webkit.org/b/61936
(though I think this test is unlikely to be the culprit there).
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug