Bug 63486 - Fix filesystem-no-callback-null-ptr-crash.html test to reference proper file api methods
Summary: Fix filesystem-no-callback-null-ptr-crash.html test to reference proper file ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Klein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-27 15:01 PDT by Adam Klein
Modified: 2011-06-28 10:40 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.63 KB, patch)
2011-06-27 15:01 PDT, Adam Klein 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Klein 2011-06-27 15:01:07 PDT 
Fix filesystem-no-callback-null-ptr-crash.html test to reference proper file api methods
Comment 1 Adam Klein 2011-06-27 15:01:28 PDT 
Created attachment 98794 [details]
Patch
Comment 2 Adam Klein 2011-06-27 15:03:42 PDT 
This test was correct when written, but the names of these methods has since changed.  However, that wasn't being noticed because they're wrapped in "try {} catch(e) {}".
Comment 3 WebKit Review Bot 2011-06-27 15:31:49 PDT 
Comment on attachment 98794 [details]
Patch

Clearing flags on attachment: 98794

Committed r89870: <http://trac.webkit.org/changeset/89870>
Comment 4 WebKit Review Bot 2011-06-27 15:31:53 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Kinuko Yasuda 2011-06-28 02:15:52 PDT 
Thanks a lot Adam for fixing this!!
Comment 6 Adam Klein 2011-06-28 10:40:07 PDT 
(In reply to comment #5)
> Thanks a lot Adam for fixing this!!

No problem.  However, it still doesn't explain the flakiness in http://webkit.org/b/61936 (though I think this test is unlikely to be the culprit there).