Bug 63471 – Extract LineBreakIteratorPool class into its own file

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Joseph Pecoraro]

Extract LineBreakIteratorPool class into it's own file.

[Joseph Pecoraro]

Created attachment 98763 [details]
[PATCH] Add LineBreakIteratorPoolICU.h

I added it to all the builds that I saw had TextBreakIteratorICU.h

[WebKit Review Bot]

Attachment 98763 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/platform/text/TextBreakIteratorICU.cpp:26:  Alphabetical sorting problem.  [build/include_order] [4]
Source/WebCore/WebCore.vcproj/WebCore.vcproj:31534:  mismatched tag  [xml/syntax] [5]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Joseph Pecoraro]

Comment on attachment 98763 [details]
[PATCH] Add LineBreakIteratorPoolICU.h

View in context: https://bugs.webkit.org/attachment.cgi?id=98763&action=review

>> Source/WebCore/platform/text/TextBreakIteratorICU.cpp:26
>> +#include "LineBreakIteratorPoolICU.h"
> 
> Alphabetical sorting problem.  [build/include_order] [4]

Whoops, twice in one week... Will fix with other review comments / before landing.

[Darin Adler]

Comment on attachment 98763 [details]
[PATCH] Add LineBreakIteratorPoolICU.h

View in context: https://bugs.webkit.org/attachment.cgi?id=98763&action=review

> Source/WebCore/platform/text/LineBreakIteratorPoolICU.h:2
> + * Copyright (C) 2006 Lars Knoll <[e-mail]>

Lars shouldn’t get copyright for this new code.

> Source/WebCore/platform/text/LineBreakIteratorPoolICU.h:3
> + * Copyright (C) 2007 Apple Inc. All rights reserved.

The code you put into this file is all new. The copyright should be 2011, not 2007.

> Source/WebCore/platform/text/LineBreakIteratorPoolICU.h:34
> +WTF_MAKE_NONCOPYABLE(LineBreakIteratorPool);

I think this should be indented.

[Joseph Pecoraro]

(In reply to comment #4)
> (From update of attachment 98763 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=98763&action=review
> 
> > Source/WebCore/platform/text/LineBreakIteratorPoolICU.h:2
> > + * Copyright (C) 2006 Lars Knoll <[e-mail]>
> 
> Lars shouldn’t get copyright for this new code.
> 
> > Source/WebCore/platform/text/LineBreakIteratorPoolICU.h:3
> > + * Copyright (C) 2007 Apple Inc. All rights reserved.
> 
> The code you put into this file is all new. The copyright should be 2011, not 2007.

Wow, I didn't realize how new it was! That sounds good.
http://trac.webkit.org/changeset/89592


> > Source/WebCore/platform/text/LineBreakIteratorPoolICU.h:34
> > +WTF_MAKE_NONCOPYABLE(LineBreakIteratorPool);
> 
> I think this should be indented.

Okay, will fix.

[Joseph Pecoraro]

Landed in r89851: <http://trac.webkit.org/changeset/89851>.