The links to crash logs in results.html include the crashing symbol. This makes it easy to see at a glance if multiple tests are crashing in the same place. It would be handy for the links to crash logs that TestFailures shows to include the crashing symbol too.
Created attachment 99301 [details] Use objects instead of strings to represent a test result in TestFailures code
Comment on attachment 99301 [details] Use objects instead of strings to represent a test result in TestFailures code r=me
Created attachment 99304 [details] Include the crashing symbol in crash logs links on TestFailures
Comment on attachment 99304 [details] Include the crashing symbol in crash logs links on TestFailures View in context: https://bugs.webkit.org/attachment.cgi?id=99304&action=review r=me > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:36 > if (cachedData.version === currentCachedDataVersion) { Shouldn't this be (cachedData.version >= 1)? Or do you only want to use the cached version if it's up-to-date? > Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:76 > + result.crashingSymbol = match[1]; You don't want to break out of the for loop here when you get a match? Or do you want the last symbol to "win"?
Comment on attachment 99304 [details] Include the crashing symbol in crash logs links on TestFailures View in context: https://bugs.webkit.org/attachment.cgi?id=99304&action=review >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:36 >> if (cachedData.version === currentCachedDataVersion) { > > Shouldn't this be (cachedData.version >= 1)? Or do you only want to use the cached version if it's up-to-date? I only want to use the cached data if it matches the current version. Otherwise the cached object might not have all the data we want. >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:76 >> + result.crashingSymbol = match[1]; > > You don't want to break out of the for loop here when you get a match? Or do you want the last symbol to "win"? Breaking out sounds good. I'll do that.
Committed r90121: <http://trac.webkit.org/changeset/90121>