Bug 63465 - Links to crash logs on TestFailures page should include the crashing symbol (like links in results.html do)
Summary: Links to crash logs on TestFailures page should include the crashing symbol (...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL: http://build.webkit.org/TestFailures/
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-27 10:23 PDT by Adam Roben (:aroben)
Modified: 2011-06-30 08:31 PDT (History)
1 user (show)

See Also:


Attachments
Use objects instead of strings to represent a test result in TestFailures code (9.01 KB, patch)
2011-06-30 07:53 PDT, Adam Roben (:aroben)
no flags Details | Formatted Diff | Diff
Include the crashing symbol in crash logs links on TestFailures (8.25 KB, patch)
2011-06-30 08:12 PDT, Adam Roben (:aroben)
ddkilzer: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-06-27 10:23:53 PDT
The links to crash logs in results.html include the crashing symbol. This makes it easy to see at a glance if multiple tests are crashing in the same place.

It would be handy for the links to crash logs that TestFailures shows to include the crashing symbol too.
Comment 1 Adam Roben (:aroben) 2011-06-30 07:53:56 PDT
Created attachment 99301 [details]
Use objects instead of strings to represent a test result in TestFailures code
Comment 2 David Kilzer (:ddkilzer) 2011-06-30 07:58:25 PDT
Comment on attachment 99301 [details]
Use objects instead of strings to represent a test result in TestFailures code

r=me
Comment 3 Adam Roben (:aroben) 2011-06-30 08:12:12 PDT
Created attachment 99304 [details]
Include the crashing symbol in crash logs links on TestFailures
Comment 4 David Kilzer (:ddkilzer) 2011-06-30 08:20:00 PDT
Comment on attachment 99304 [details]
Include the crashing symbol in crash logs links on TestFailures

View in context: https://bugs.webkit.org/attachment.cgi?id=99304&action=review

r=me

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:36
>              if (cachedData.version === currentCachedDataVersion) {

Shouldn't this be (cachedData.version >= 1)?  Or do you only want to use the cached version if it's up-to-date?

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:76
> +                            result.crashingSymbol = match[1];

You don't want to break out of the for loop here when you get a match?  Or do you want the last symbol to "win"?
Comment 5 Adam Roben (:aroben) 2011-06-30 08:22:06 PDT
Comment on attachment 99304 [details]
Include the crashing symbol in crash logs links on TestFailures

View in context: https://bugs.webkit.org/attachment.cgi?id=99304&action=review

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:36
>>              if (cachedData.version === currentCachedDataVersion) {
> 
> Shouldn't this be (cachedData.version >= 1)?  Or do you only want to use the cached version if it's up-to-date?

I only want to use the cached data if it matches the current version. Otherwise the cached object might not have all the data we want.

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestResultsLoader.js:76
>> +                            result.crashingSymbol = match[1];
> 
> You don't want to break out of the for loop here when you get a match?  Or do you want the last symbol to "win"?

Breaking out sounds good. I'll do that.
Comment 6 Adam Roben (:aroben) 2011-06-30 08:31:32 PDT
Committed r90121: <http://trac.webkit.org/changeset/90121>