Bug 63454 - [Qt][WK2] netscape-dom-access.html needs new result
Summary: [Qt][WK2] netscape-dom-access.html needs new result
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P3 Normal
Assignee: Balazs Kelemen
URL:
Keywords: LayoutTestFailure, Qt, QtTriaged
Depends on:
Blocks:
 
Reported: 2011-06-27 07:58 PDT by Balazs Kelemen
Modified: 2011-08-25 01:33 PDT (History)
1 user (show)

See Also:


Attachments
Patch (2.40 KB, patch)
2011-06-27 08:07 PDT, Balazs Kelemen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Balazs Kelemen 2011-06-27 07:58:33 PDT
The WK1 expected file contains a block for the Qt platform plugin widget:
[QT: geometry: {at (11,71) size 200x200} isHidden: 0 isSelfVisible: 1 isParentVisible: 1 mask: {at (0,0) size 200x200} ] 

Since WK2 has no concept of platform plugins we need to remove this from the expected file.
Comment 1 Balazs Kelemen 2011-06-27 08:07:50 PDT
Created attachment 98728 [details]
Patch
Comment 2 Andreas Kling 2011-07-01 08:43:19 PDT
Comment on attachment 98728 [details]
Patch

rs=me
Comment 3 WebKit Review Bot 2011-07-01 08:46:10 PDT
Comment on attachment 98728 [details]
Patch

Rejecting attachment 98728 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-03', '--port..." exit_code: 2

Last 500 characters of output:
" exit_code: 1

Parsed 3 diffs from patch file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/platform/qt-wk2/Skipped
Hunk #1 FAILED at 1493.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/platform/qt-wk2/Skipped.rej
patching file LayoutTests/platform/qt-wk2/plugins/netscape-dom-access-expected.txt

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Andreas Kling', u'--fo..." exit_code: 1

Full output: http://queues.webkit.org/results/8977006
Comment 4 Balazs Kelemen 2011-08-25 01:31:51 PDT
Landed in r90258 (long time ago).