RESOLVED FIXED 63450
Web Inspector: create status bar buttons programmatically. Add "Inspect" button to all panels. 
https://bugs.webkit.org/show_bug.cgi?id=63450
Summary Web Inspector: create status bar buttons programmatically. Add "Inspect" butt...
Pavel Feldman
Reported 2011-06-27 06:37:13 PDT
Buttons should be created in code, not in HTML. Also making Inspect Element action available on all panels (as an experiment).
Attachments
Patch (11.38 KB, patch)
2011-06-27 06:40 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Patch (11.26 KB, patch)
2011-06-27 07:58 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Patch (11.05 KB, patch)
2011-06-28 08:40 PDT, Pavel Feldman 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Pavel Feldman
Comment 1 2011-06-27 06:40:29 PDT
Created attachment 98715 [details] Patch
Pavel Feldman
Comment 2 2011-06-27 07:58:11 PDT
Created attachment 98726 [details] Patch
Yury Semikhatsky
Comment 3 2011-06-28 02:39:13 PDT
Comment on attachment 98726 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98726&action=review > Source/WebCore/inspector/front-end/inspector.js:189 > + anchoredStatusBar.appendChild(this.panels.elements.nodeSearchButton.element); There is no Elements panel in worker inspector window, please add a check. > Source/WebCore/inspector/front-end/inspector.js:210 > + this._dockToggleButton.title = WebInspector.UIString("Undock into separate window."); Would be nice to have a toggle button that would automatically switch between two titles.
Pavel Feldman
Comment 4 2011-06-28 08:40:44 PDT
Created attachment 98930 [details] Patch
Pavel Feldman
Comment 5 2011-06-29 06:58:19 PDT
Comment on attachment 98930 [details] Patch Clearing flags on attachment: 98930 Committed r90014: <http://trac.webkit.org/changeset/90014>
Pavel Feldman
Comment 6 2011-06-29 06:58:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.