Bug 63448 - [Qt] Remove Phonon MediaPlayer from the tree.
: [Qt] Remove Phonon MediaPlayer from the tree.
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: WebKit Qt
: 528+ (Nightly build)
: PC Linux
: P2 Normal
Assigned To: Alexis Menard (darktears)
: Qt, QtTriaged
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-27 06:26 PDT by Alexis Menard (darktears)
Modified: 2011-06-27 11:15 PDT (History)
8 users (show)

See Also:


Attachments
Patch (30.03 KB, patch)
2011-06-27 07:01 PDT, Alexis Menard (darktears)
no flags Details | Formatted Diff | Diff
Patch for landing (30.10 KB, patch)
2011-06-27 10:07 PDT, Alexis Menard (darktears)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexis Menard (darktears) 2011-06-27 06:26:43 PDT
[Qt] Remove Phonon MediaPlayer from the tree.
Comment 1 Alexis Menard (darktears) 2011-06-27 07:01:41 PDT
Created attachment 98718 [details]
Patch
Comment 2 Sam Weinig 2011-06-27 09:42:31 PDT
Not that object to removing things, but I am curious why? Is Phonon dead?
Comment 3 Kenneth Rohde Christiansen 2011-06-27 09:47:02 PDT
(In reply to comment #2)
> Not that object to removing things, but I am curious why? Is Phonon dead?

Phonon is deprecated within Qt (but still lives a life on its own as part of the KDE project). It also never worked properly for QtWebKit and noone is maintaining the current code.

Our current path is using GStreamer directly on Linux, Quicktime on Mac (and Windows if available). For other cases we will be using QtMultimedia. This provides a better experience for our users and GStreamer is already the backend we are using on the Nokia N9.
Comment 4 Kenneth Rohde Christiansen 2011-06-27 09:48:22 PDT
Comment on attachment 98718 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98718&action=review

> Source/WebKit/qt/docs/qtwebkit.qdocconf:167
> +                          K_DECLARE_PRIVATE

K_? Sounds like some KDE thing, not related to Phonon?
Comment 5 Alexis Menard (darktears) 2011-06-27 10:03:32 PDT
(In reply to comment #4)
> (From update of attachment 98718 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=98718&action=review
> 
> > Source/WebKit/qt/docs/qtwebkit.qdocconf:167
> > +                          K_DECLARE_PRIVATE
> 
> K_? Sounds like some KDE thing, not related to Phonon?

May be, I'll remove it then.
Comment 6 Alexis Menard (darktears) 2011-06-27 10:04:47 PDT
(In reply to comment #5)
> (In reply to comment #4)
> > (From update of attachment 98718 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=98718&action=review
> > 
> > > Source/WebKit/qt/docs/qtwebkit.qdocconf:167
> > > +                          K_DECLARE_PRIVATE
> > 
> > K_? Sounds like some KDE thing, not related to Phonon?
> 
> May be, I'll remove it then.

And will land it manually then, thanks for the review.
Comment 7 Alexis Menard (darktears) 2011-06-27 10:07:25 PDT
Created attachment 98742 [details]
Patch for landing
Comment 8 WebKit Review Bot 2011-06-27 10:24:47 PDT
The commit-queue encountered the following flaky tests while processing attachment 98742 [details]:

http/tests/local/fileapi/send-dragged-file.html bug 62791 (author: jianli@chromium.org)
The commit-queue is continuing to process your patch.
Comment 9 WebKit Review Bot 2011-06-27 10:26:45 PDT
Comment on attachment 98742 [details]
Patch for landing

Clearing flags on attachment: 98742

Committed r89832: <http://trac.webkit.org/changeset/89832>
Comment 10 WebKit Review Bot 2011-06-27 10:26:51 PDT
All reviewed patches have been landed.  Closing bug.
Comment 11 Ademar Reis 2011-06-27 11:15:27 PDT
Revision r89832 cherry-picked into qtwebkit-2.2 with commit 312ffd4 <http://gitorious.org/webkit/qtwebkit/commit/312ffd4>