RESOLVED WONTFIX 63443
[V8] Add missing compile guards for V8Proxy and V8DOMWrapper. 
https://bugs.webkit.org/show_bug.cgi?id=63443
Summary [V8] Add missing compile guards for V8Proxy and V8DOMWrapper.
Gwang Yoon Hwang
Reported 2011-06-27 04:52:18 PDT
[V8] Add missing compile guards for V8Proxy and V8DOMWrapper.
Attachments
Patch (2.47 KB, patch)
2011-06-27 04:53 PDT, Gwang Yoon Hwang 		japhet: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gwang Yoon Hwang
Comment 1 2011-06-27 04:53:39 PDT
Created attachment 98702 [details] Patch
Nate Chapin
Comment 2 2011-06-28 17:14:19 PDT
Comment on attachment 98702 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98702&action=review > Source/WebCore/bindings/v8/V8DOMWrapper.cpp:53 > +#if ENABLE(FILE_SYSTEM) > #include "V8FileWriter.h" > +#endif // ENABLE(FILE_SYSTEM) #if ENABLE() shouldn't be necessary around #includes. CodeGeneratorV8.pm should correctly putt #if ENABLE() guards around the generated binding headers. If it isn't properly guarding the headers, we should fix the bug there. :)
Gwang Yoon Hwang
Comment 3 2011-06-28 17:31:49 PDT
Thanks for review Nate! I'll check CodeGeneratorV8.pm for guards.
Anders Carlsson
Comment 4 2013-05-02 11:12:11 PDT
V8 is gone from WebKit.
Note You need to log in before you can comment on or make changes to this bug.