Bug 63443 - [V8] Add missing compile guards for V8Proxy and V8DOMWrapper.
Summary: [V8] Add missing compile guards for V8Proxy and V8DOMWrapper.
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-27 04:52 PDT by Gwang Yoon Hwang
Modified: 2013-05-02 11:12 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.47 KB, patch)
2011-06-27 04:53 PDT, Gwang Yoon Hwang
japhet: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gwang Yoon Hwang 2011-06-27 04:52:18 PDT
[V8] Add missing compile guards for V8Proxy and V8DOMWrapper.
Comment 1 Gwang Yoon Hwang 2011-06-27 04:53:39 PDT
Created attachment 98702 [details]
Patch
Comment 2 Nate Chapin 2011-06-28 17:14:19 PDT
Comment on attachment 98702 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98702&action=review

> Source/WebCore/bindings/v8/V8DOMWrapper.cpp:53
> +#if ENABLE(FILE_SYSTEM)
>  #include "V8FileWriter.h"
> +#endif // ENABLE(FILE_SYSTEM)

#if ENABLE() shouldn't be necessary around #includes.  CodeGeneratorV8.pm should correctly putt #if ENABLE() guards around the generated binding headers.

If it isn't properly guarding the headers, we should fix the bug there. :)
Comment 3 Gwang Yoon Hwang 2011-06-28 17:31:49 PDT
Thanks for review Nate!

I'll check CodeGeneratorV8.pm for guards.
Comment 4 Anders Carlsson 2013-05-02 11:12:11 PDT
V8 is gone from WebKit.