Bug 63430 - Remove evil uses of hasattr
Summary: Remove evil uses of hasattr
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-27 00:21 PDT by Eric Seidel (no email)
Modified: 2011-06-27 01:42 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.64 KB, patch)
2011-06-27 00:27 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2011-06-27 00:21:23 PDT 
Remove evil uses of hasattr
Comment 1 Eric Seidel (no email) 2011-06-27 00:27:50 PDT 
Created attachment 98673 [details]
Patch
Comment 2 Adam Barth 2011-06-27 00:29:25 PDT 
Comment on attachment 98673 [details]
Patch

Ok.  I assume you ran the unit tests.  We should also be watching the Chromium canaries to see if we're breaking them.
Comment 3 WebKit Review Bot 2011-06-27 01:42:07 PDT 
Comment on attachment 98673 [details]
Patch

Clearing flags on attachment: 98673

Committed r89808: <http://trac.webkit.org/changeset/89808>
Comment 4 WebKit Review Bot 2011-06-27 01:42:12 PDT 
All reviewed patches have been landed.  Closing bug.