Bug 63420 - Scrolling doesn't continue when moving to the other scroll arrow
Summary: Scrolling doesn't continue when moving to the other scroll arrow
Status: UNCONFIRMED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.6
: P2 Minor
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-26 22:54 PDT by eustas.bug
Modified: 2011-06-28 00:52 PDT (History)
2 users (show)

See Also:


Attachments
Fix: Scrolling doesn't continue when moving to the other scroll arrow (Chrome) (2.94 KB, patch)
2011-06-27 01:15 PDT, eustas.bug
no flags Details | Formatted Diff | Diff
Fix: Scrolling doesn't continue when moving to the other scroll arrow (Chrome) (2.99 KB, patch)
2011-06-27 02:18 PDT, eustas.bug
ap: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description eustas.bug 2011-06-26 22:54:21 PDT
See chromium issue #33268

Behavior in Safari 3.x/4.x (if applicable): OK
Behavior in Chrome: bad

What steps will reproduce the problem?
1. Hold mouse down over a scrollbar arrow
2. Continue holding mouse and point to the scroll arrow in the other 
direction

What is the expected result?
Scrolling continues in the other direction

What happens instead?
Scrolling stops, first scroll arrow remains highlighted
Comment 1 eustas.bug 2011-06-27 01:15:50 PDT
Created attachment 98679 [details]
Fix: Scrolling doesn't continue when moving to the other scroll arrow (Chrome)
Comment 2 WebKit Review Bot 2011-06-27 01:22:16 PDT
Attachment 98679 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/ChangeLog:1:  ChangeLog entry has no bug number  [changelog/bugnumber] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 eustas.bug 2011-06-27 02:18:58 PDT
Created attachment 98688 [details]
Fix: Scrolling doesn't continue when moving to the other scroll arrow (Chrome)
Comment 4 Alexey Proskuryakov 2011-06-27 11:51:48 PDT
This patch is in cross platform code, but it only intends to fix Chrome. Why was changing cross platform code needed?

+        No new tests. (OOPS!)

Why is it OK to have no tests?
Comment 5 eustas.bug 2011-06-27 22:03:51 PDT
(In reply to comment #4)
> This patch is in cross platform code, but it only intends to fix Chrome. Why was changing cross platform code needed?

Bug description is not complete.

Initially it was reported that window scrollbar behaves differently on Safari and Chrome.

Chrome window scrollbar wrong behavior comes from cross-platform code.

But is Safari this code also leads to inconsistent user experience: while window scrollbar behaves good, all html scrollbars behave wrong (as Chrome-window scrollbar)

That is why it is better to fix scrollbar behavior in cross platform code: it will give consistent and user expected behavior both in Safari and Chrome.
Comment 6 Alexey Proskuryakov 2011-06-28 00:52:55 PDT
Comment on attachment 98688 [details]
Fix: Scrolling doesn't continue when moving to the other scroll arrow (Chrome)

Thank you, this explanation makes sense.

The patch still needs a regression test though, so I'm marking it r- just for that.