Bug 63416 - Remove LegacyDefaultOptionalArguments from WebAudio IDL files
Summary: Remove LegacyDefaultOptionalArguments from WebAudio IDL files
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-26 20:17 PDT by Adam Barth
Modified: 2011-06-26 23:49 PDT (History)
4 users (show)

See Also:


Attachments
Patch (7.59 KB, patch)
2011-06-26 20:20 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2011-06-26 20:17:33 PDT
Remove LegacyDefaultOptionalArguments from WebAudio IDL files
Comment 1 Adam Barth 2011-06-26 20:20:54 PDT
Created attachment 98657 [details]
Patch
Comment 2 Adam Barth 2011-06-26 20:22:04 PDT
Are there any tests for WebAudio?  I didn't see any in the LayoutTests directory.
Comment 3 Chris Rogers 2011-06-26 21:07:32 PDT
They're coming soon.  90% of the work has been finished for DRT and run-webkit-tests.  I have seven tests ready to go - more to follow.
Comment 4 Adam Barth 2011-06-26 21:11:14 PDT
> They're coming soon.  90% of the work has been finished for DRT and run-webkit-tests.  I have seven tests ready to go - more to follow.

How does this patch look to you?  (I'm happy to add tests for this change once there are some tests to use as templates.)
Comment 5 Chris Rogers 2011-06-26 21:43:17 PDT
Looking over this it seems fine.  I'll keep an eye out in the next day or so after landing just to be sure that everthing is ok.
Comment 6 Chris Rogers 2011-06-26 21:52:16 PDT
Concerning:


// FIXME: Why does this method need to be Custom?
[Custom] void connect(in AudioNode destination, in [Optional] unsigned long output, in [Optional] unsigned long input)
    raises(DOMException);



When this was originally landed, either the IDL generation didn't support the optional arguments, or I didn't know about it :)
This is an important method, so we'll have to be careful to test it correctly before removing the custom bindings.
Comment 7 Adam Barth 2011-06-26 22:09:53 PDT
Yep, which is why I didn't make the change in this patch :)
Comment 8 Eric Seidel (no email) 2011-06-26 23:04:47 PDT
Comment on attachment 98657 [details]
Patch

OK.
Comment 9 WebKit Review Bot 2011-06-26 23:49:29 PDT
Comment on attachment 98657 [details]
Patch

Clearing flags on attachment: 98657

Committed r89789: <http://trac.webkit.org/changeset/89789>
Comment 10 WebKit Review Bot 2011-06-26 23:49:34 PDT
All reviewed patches have been landed.  Closing bug.