Bug 63382 – run-bindings-tests does not work on Chromium Windows.

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Dimitri Glazkov (Google)]

run-bindings-tests does not work on Chromium Windows.

[Dimitri Glazkov (Google)]

Created attachment 98593 [details]
Patch

[Dimitri Glazkov (Google)]

Comment on attachment 98593 [details]
Patch

Bill, the master needs to restart once this patch lands.

[Dimitri Glazkov (Google)]

The "does not work" looks like this:

Traceback (most recent call last):
  File "./Tools/Scripts/run-bindings-tests", line 139, in <module>
    sys.exit(main(sys.argv))
  File "./Tools/Scripts/run-bindings-tests", line 111, in main
    current_scm = scm.detect_scm_system(os.curdir)
  File "E:\google-windows-2\chromium-win-release-tests\build\Tools\Scripts\webkitpy\common\checkout\scm\detection.py", line 79, in detect_scm_system
    return SVN(cwd=absolute_path, patch_directories=patch_directories)
  File "E:\google-windows-2\chromium-win-release-tests\build\Tools\Scripts\webkitpy\common\checkout\scm\svn.py", line 68, in __init__
    SCM.__init__(self, cwd, executive)
  File "E:\google-windows-2\chromium-win-release-tests\build\Tools\Scripts\webkitpy\common\checkout\scm\scm.py", line 66, in __init__
    self.checkout_root = self.find_checkout_root(self.cwd)
  File "E:\google-windows-2\chromium-win-release-tests\build\Tools\Scripts\webkitpy\common\checkout\scm\svn.py", line 99, in find_checkout_root
    uuid = SVN.find_uuid(path)
  File "E:\google-windows-2\chromium-win-release-tests\build\Tools\Scripts\webkitpy\common\checkout\scm\svn.py", line 86, in find_uuid
    return cls.value_from_svn_info(path, 'Repository UUID')
  File "E:\google-windows-2\chromium-win-release-tests\build\Tools\Scripts\webkitpy\common\checkout\scm\svn.py", line 91, in value_from_svn_info
    info_output = run_command(svn_info_args).rstrip()
  File "E:\google-windows-2\chromium-win-release-tests\build\Tools\Scripts\webkitpy\common\system\executive.py", line 102, in run_command
    return Executive().run_command(*args, **kwargs)
  File "E:\google-windows-2\chromium-win-release-tests\build\Tools\Scripts\webkitpy\common\system\executive.py", line 385, in run_command
    close_fds=self._should_close_fds())
  File "E:\google-windows-2\chromium-win-release-tests\build\Tools\Scripts\webkitpy\common\system\executive.py", line 441, in popen
    return subprocess.Popen(*args, **kwargs)
  File "c:\Python26\lib\subprocess.py", line 623, in __init__
    errread, errwrite)
  File "c:\Python26\lib\subprocess.py", line 833, in _execute_child
    startupinfo)
WindowsError: [Error 2] The system cannot find the file specified

[Adam Barth]

Comment on attachment 98593 [details]
Patch

dglazkov wins the prize for fixing a bug by changing only whitespace.

[Dimitri Glazkov (Google)]

(In reply to comment #4)
> (From update of attachment 98593 [details])
> dglazkov wins the prize for fixing a bug by changing only whitespace.

I would like to thank the Academy and especially Python, who provided this glorious opportunity.

[WebKit Review Bot]

Comment on attachment 98593 [details]
Patch

Clearing flags on attachment: 98593

Committed r89746: <http://trac.webkit.org/changeset/89746>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.

[William Siegrist]

Master updated.