Bug 63372 - convert editing/deleting/whitespace-pre-1.html to dumpAsText
Summary: convert editing/deleting/whitespace-pre-1.html to dumpAsText
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-24 18:09 PDT by Wyatt Carss
Modified: 2011-06-27 14:38 PDT (History)
6 users (show)

See Also:


Attachments
Patch (76.71 KB, patch)
2011-06-24 18:12 PDT, Wyatt Carss
no flags Details | Formatted Diff | Diff
Patch (77.20 KB, patch)
2011-06-27 12:11 PDT, Wyatt Carss
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wyatt Carss 2011-06-24 18:09:23 PDT
convert editing/deleting/whitespace-pre-1.html to dumpAsText
Comment 1 Wyatt Carss 2011-06-24 18:12:08 PDT
Created attachment 98570 [details]
Patch
Comment 2 Ryosuke Niwa 2011-06-24 18:53:28 PDT
Comment on attachment 98570 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98570&action=review

> LayoutTests/editing/deleting/whitespace-pre-1.html:4
>  if (window.layoutTestController)
>       layoutTestController.dumpEditingCallbacks();
> +     layoutTestController.dumpAsText();

You need curly brackets around these two statements.  Otherwise, we'll get script errors when we run it manually on a browser.  Also I'd use dump-as-markup.js to see the markup.
Comment 3 Wyatt Carss 2011-06-27 12:11:24 PDT
Created attachment 98764 [details]
Patch
Comment 4 WebKit Review Bot 2011-06-27 14:38:51 PDT
Comment on attachment 98764 [details]
Patch

Clearing flags on attachment: 98764

Committed r89862: <http://trac.webkit.org/changeset/89862>
Comment 5 WebKit Review Bot 2011-06-27 14:38:55 PDT
All reviewed patches have been landed.  Closing bug.