RESOLVED FIXED 63361
add flexbox and inline-flexbox as possible CSS display values 
https://bugs.webkit.org/show_bug.cgi?id=63361
Summary add flexbox and inline-flexbox as possible CSS display values
Tony Chang
Reported 2011-06-24 15:41:46 PDT
add flexbox and inline-flexbox as possible CSS display values
Attachments
Patch (5.63 KB, patch)
2011-06-24 15:42 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.55 KB, patch)
2011-06-24 15:57 PDT, Tony Chang 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2011-06-24 15:42:17 PDT
Created attachment 98554 [details] Patch
Ojan Vafai
Comment 2 2011-06-24 15:54:10 PDT
Comment on attachment 98554 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98554&action=review > LayoutTests/css3/flexbox/script-tests/display-property.js:6 > +function testFlex(displayValue) > +{ > + return div.style[styleAttribute]; > +} Unused. > LayoutTests/css3/flexbox/script-tests/display-property.js:11 > +div.style.display = '-webkit-flexbox'; > +shouldBeEqualToString('div.style.display', '-webkit-flexbox'); You could move this into testFlex. > Source/WebCore/css/CSSParser.cpp:972 > + // table-column-group | table-column | table-cell | table-caption | -webkit-box | -webkit-inline-box | none | inherit Should this include -webkit-flexbox and -webkit-inline-flexbox? Not really sure this comment is useful though.
Tony Chang
Comment 3 2011-06-24 15:57:15 PDT
Created attachment 98556 [details] Patch for landing
WebKit Review Bot
Comment 4 2011-06-24 16:39:47 PDT
Comment on attachment 98556 [details] Patch for landing Clearing flags on attachment: 98556 Committed r89712: <http://trac.webkit.org/changeset/89712>
WebKit Review Bot
Comment 5 2011-06-24 16:39:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.