Bug 63352 - The fast/js/recursion-limit-equal test is too fragile
Summary: The fast/js/recursion-limit-equal test is too fragile
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-24 13:41 PDT by Filip Pizlo
Modified: 2011-06-27 11:40 PDT (History)
3 users (show)

See Also:


Attachments
the patch (1.85 KB, patch)
2011-06-24 13:44 PDT, Filip Pizlo
barraclough: review+
webkit.review.bot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ec2-cr-linux-03 (1.47 MB, application/zip)
2011-06-24 14:14 PDT, WebKit Review Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2011-06-24 13:41:35 PDT
The fast/js/recursion-limit-equal test validates that the JavaScriptCore engine can throw a RangeError correctly in a recursion function that tests equality.  However, its present design asserts that the RangeError is thrown from the point of recursion rather than from any of the other points in the function.  Small changes in the system may change where the RangeError is thrown, which results in the test failing.  This contradicts the definition of the test: the test is meant to succeed so long as a RangeError is thrown, regardless of which line number in the test function triggers the runtime to throw the error.
Comment 1 Filip Pizlo 2011-06-24 13:44:32 PDT
Created attachment 98533 [details]
the patch
Comment 2 Gavin Barraclough 2011-06-24 13:47:54 PDT
Comment on attachment 98533 [details]
the patch

Great
Comment 3 WebKit Review Bot 2011-06-24 14:14:37 PDT
Comment on attachment 98533 [details]
the patch

Attachment 98533 [details] did not pass chromium-ews (chromium-xvfb):
Output: http://queues.webkit.org/results/8934578

New failing tests:
fast/js/recursion-limit-equal.html
Comment 4 WebKit Review Bot 2011-06-24 14:14:42 PDT
Created attachment 98539 [details]
Archive of layout-test-results from ec2-cr-linux-03

The attached test failures were seen while running run-webkit-tests on the chromium-ews.
Bot: ec2-cr-linux-03  Port: Chromium  Platform: Linux-2.6.35-28-virtual-x86_64-with-Ubuntu-10.10-maverick
Comment 5 Gavin Barraclough 2011-06-27 11:40:42 PDT
Landed in r89842