Bug 63348 - Bugs filed from TestFailures page should include links to Trac for suspect revisions
Summary: Bugs filed from TestFailures page should include links to Trac for suspect re...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL: http://build.webkit.org/TestFailures/
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-24 13:30 PDT by Adam Roben (:aroben)
Modified: 2011-06-24 13:55 PDT (History)
1 user (show)

See Also:


Attachments
Include links to Trac in bugs filed from TestFailures (5.04 KB, patch)
2011-06-24 13:34 PDT, Adam Roben (:aroben)
ddkilzer: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2011-06-24 13:30:31 PDT
It would be handy for the bugs filed from the TestFailures page to include links to Trac for suspect revisions.
Comment 1 Adam Roben (:aroben) 2011-06-24 13:34:57 PDT
Created attachment 98529 [details]
Include links to Trac in bugs filed from TestFailures
Comment 2 David Kilzer (:ddkilzer) 2011-06-24 13:42:43 PDT
Comment on attachment 98529 [details]
Include links to Trac in bugs filed from TestFailures

View in context: https://bugs.webkit.org/attachment.cgi?id=98529&action=review

r=me

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:309
> +                endOfFirstSentence += ' in r' + firstSuspectRevision + ' <' + this._trac.changesetURL(firstSuspectRevision) + '>';

Nit: I like revision links to include the "r", but maybe that's more trouble than it's worth.
Comment 3 Adam Roben (:aroben) 2011-06-24 13:46:41 PDT
Comment on attachment 98529 [details]
Include links to Trac in bugs filed from TestFailures

View in context: https://bugs.webkit.org/attachment.cgi?id=98529&action=review

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:309
>> +                endOfFirstSentence += ' in r' + firstSuspectRevision + ' <' + this._trac.changesetURL(firstSuspectRevision) + '>';
> 
> Nit: I like revision links to include the "r", but maybe that's more trouble than it's worth.

I'm not sure what you mean? This is just putting the URL into the description after the revision number. Something like:

foo/bar/baz.html started failing on Windows 7 Release (Tests) in r12345 <http://trac.webkit.org/changeset/12345>.
Comment 4 David Kilzer (:ddkilzer) 2011-06-24 13:50:28 PDT
(In reply to comment #3)
> (From update of attachment 98529 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=98529&action=review
> 
> >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:309
> >> +                endOfFirstSentence += ' in r' + firstSuspectRevision + ' <' + this._trac.changesetURL(firstSuspectRevision) + '>';
> > 
> > Nit: I like revision links to include the "r", but maybe that's more trouble than it's worth.
> 
> I'm not sure what you mean? This is just putting the URL into the description after the revision number. Something like:
> 
> foo/bar/baz.html started failing on Windows 7 Release (Tests) in r12345 <http://trac.webkit.org/changeset/12345>.

Sorry, I thought it was doing something like this:

r<a href="http://trac.webkit.org/changeset/12345">12345</a>

That's fine.
Comment 5 Adam Roben (:aroben) 2011-06-24 13:55:36 PDT
Committed r89701: <http://trac.webkit.org/changeset/89701>