Bug 63348 – Bugs filed from TestFailures page should include links to Trac for suspect revisions

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Adam Roben (:aroben)]

It would be handy for the bugs filed from the TestFailures page to include links to Trac for suspect revisions.

[Adam Roben (:aroben)]

Created attachment 98529 [details]
Include links to Trac in bugs filed from TestFailures

[David Kilzer (:ddkilzer)]

Comment on attachment 98529 [details]
Include links to Trac in bugs filed from TestFailures

View in context: https://bugs.webkit.org/attachment.cgi?id=98529&action=review

r=me

> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:309
> +                endOfFirstSentence += ' in r' + firstSuspectRevision + ' <' + this._trac.changesetURL(firstSuspectRevision) + '>';

Nit: I like revision links to include the "r", but maybe that's more trouble than it's worth.

[Adam Roben (:aroben)]

Comment on attachment 98529 [details]
Include links to Trac in bugs filed from TestFailures

View in context: https://bugs.webkit.org/attachment.cgi?id=98529&action=review

>> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:309
>> +                endOfFirstSentence += ' in r' + firstSuspectRevision + ' <' + this._trac.changesetURL(firstSuspectRevision) + '>';
> 
> Nit: I like revision links to include the "r", but maybe that's more trouble than it's worth.

I'm not sure what you mean? This is just putting the URL into the description after the revision number. Something like:

foo/bar/baz.html started failing on Windows 7 Release (Tests) in r12345 <http://trac.webkit.org/changeset/12345>.

[David Kilzer (:ddkilzer)]

(In reply to comment #3)
> (From update of attachment 98529 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=98529&action=review
> 
> >> Tools/BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:309
> >> +                endOfFirstSentence += ' in r' + firstSuspectRevision + ' <' + this._trac.changesetURL(firstSuspectRevision) + '>';
> > 
> > Nit: I like revision links to include the "r", but maybe that's more trouble than it's worth.
> 
> I'm not sure what you mean? This is just putting the URL into the description after the revision number. Something like:
> 
> foo/bar/baz.html started failing on Windows 7 Release (Tests) in r12345 <http://trac.webkit.org/changeset/12345>.

Sorry, I thought it was doing something like this:

r<a href="http://trac.webkit.org/changeset/12345">12345</a>

That's fine.

[Adam Roben (:aroben)]

Committed r89701: <http://trac.webkit.org/changeset/89701>