Bug 63343 – REGRESSION (r89687): 5 compositing/rtl tests failing on Windows 7 Release (Tests)

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Adam Roben (:aroben)]

The following tests have been failing on Windows 7 Release (Tests) since r89687:

    compositing/rtl/rtl-iframe-absolute-overflow.html
    compositing/rtl/rtl-iframe-absolute.html
    compositing/rtl/rtl-iframe-fixed-overflow.html
    compositing/rtl/rtl-iframe-fixed.html
    compositing/rtl/rtl-iframe-relative.html

http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r89686%20(14134)/results.html passed
http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r89687%20(14135)/results.html failed

[Adam Roben (:aroben)]

All the failure diffs show two layers that are either 44px or 45px too short.

[Brian Weinstein]

These tests were skipped on Mac when they landed, with a comment.

# https://bugs.webkit.org/show_bug.cgi?id=63282 layerTreeAsText doesn't work for iframes

Do we need to do the same for Windows?

[Adrienne Walker]

Windows should probably be marked skipped as well.  I'll take care of this.

[Adrienne Walker]

(In reply to comment #3)
> Windows should probably be marked skipped as well.  I'll take care of this.

Actually, scratch that.  Looking at the results, bug 63282 doesn't seem applicable.  There were no results at all on Snow Leopard, which is why I skipped them there.  However, there are results here so they shouldn't be skipped.

I suspect the issue is font metric differences on the element containing the layerTreeAsText output that are showing up in the graphics layer tree.

Is there a better way to get layerTreeAsText dumps that don't change the pixel results and also don't change the output of the graphics layer tree? I put them offscreen at 10000px in a <pre> tag, but they got composited when put into an iframe.

Should I just make this element use the Ahem font or is there some better way to be doing this?

[Simon Fraser (smfr)]

Do you care about the render tree dump? You could dumpAsText(true).

[Adrienne Walker]

(In reply to comment #5)
> Do you care about the render tree dump? You could dumpAsText(true).

I am doing that already.

The problem is that I have a test that adds layerTreeAsText into a <pre> element.  Then I include that test in an iframe which gets composited in a second test.  The element bounds with the text of the iframe's layer tree affects the graphics layer tree of the containing second test, which is why this is failing here.

[Simon Fraser (smfr)]

Give the iframe document's body a fixed height with overflow:hidden?

[Adrienne Walker]

Created attachment 98548 [details]
Patch

[Adrienne Walker]

Committed r89709: <http://trac.webkit.org/changeset/89709>