Bug 63341 - Pass Strings by const reference to functions
Summary: Pass Strings by const reference to functions
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tony Chang
Depends on:
Reported: 2011-06-24 12:27 PDT by Tony Chang
Modified: 2011-06-27 09:43 PDT (History)
3 users (show)

See Also:

Patch (14.47 KB, patch)
2011-06-24 12:29 PDT, Tony Chang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2011-06-24 12:27:32 PDT
Pass Strings by const reference to functions
Comment 1 Tony Chang 2011-06-24 12:29:31 PDT
Created attachment 98524 [details]
Comment 2 Tony Chang 2011-06-24 12:30:58 PDT
This is the last patch for fixing passing String by value in WebCore.  The only trickiness is in FrameLoader.cpp.
Comment 3 WebKit Review Bot 2011-06-24 15:05:30 PDT
Comment on attachment 98524 [details]

Clearing flags on attachment: 98524

Committed r89707: <http://trac.webkit.org/changeset/89707>
Comment 4 WebKit Review Bot 2011-06-24 15:05:34 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Darin Adler 2011-06-24 17:12:06 PDT
This broke the Windows build since String::charactersWithNullTermination is a non-const function.
Comment 6 Darin Adler 2011-06-24 17:13:58 PDT
I tried to fix that in <http://trac.webkit.org/changeset/89717>.
Comment 7 Tony Chang 2011-06-27 09:43:03 PDT
(In reply to comment #6)
> I tried to fix that in <http://trac.webkit.org/changeset/89717>.

Sorry.  Thanks for fixing!