Bug 63332 – Safari will quit unexpectedly when launching Safari in the first time (crash in initQTSecurityPolicyNoLocalToRemoteSiteAttribute)

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

Safari will quit unexpectedly when launching Safari in the first time (crash in initQTSecurityPolicyNoLocalToRemoteSiteAttribute)

[Jer Noble]

Only occurs on Leopard if QTKit < 7.6.3 is installed. 

<rdar://problem/9661650>

[Jer Noble]

Created attachment 98511 [details]
Patch

[Eric Carlson]

Comment on attachment 98511 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98511&action=review

> Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:252
> +    if (QTSecurityPolicyNoRemoteToLocalSiteAttribute) {
> +        [movieAttributes setValue:[NSNumber numberWithBool:NO] forKey:QTSecurityPolicyNoCrossSiteAttribute];
> +        [movieAttributes setValue:[NSNumber numberWithBool:YES] forKey:QTSecurityPolicyNoRemoteToLocalSiteAttribute];
> +        [movieAttributes setValue:[NSNumber numberWithBool:YES] forKey:QTSecurityPolicyNoLocalToRemoteSiteAttribute];
> +    } else
> +        [movieAttributes setValue:[NSNumber numberWithBool:YES] forKey:QTSecurityPolicyNoCrossSiteAttribute];
> +

SOFT_LINK_POINTER asserts in a debug build. You might add a SOFT_LINK_POINTER_OPTIONAL version that does not.

[Jer Noble]

Created attachment 98515 [details]
Patch

Addressed Eric's comment by adding SOFT_LINK_POINTER_OPTIONAL.

[Eric Carlson]

Comment on attachment 98515 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98515&action=review

> Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:246
> +    // Check to see if QTKit >= 7.6.3 is installed, which defines NoRemoteToLocal and NoLocalToRemote.
> +    // If not, just set NoCrossSite = YES, which does the same thing as NoRemoteToLocal = YES and 
> +    // NoLocalToRemote = YES in QTKit < 7.6.3.

We don't actually check the QTKit version here, so it would probably be better to say something like "... see if the current version of QTKit has NoRemoteToLocal ..." instead.

[Jer Noble]

(In reply to comment #5)
> (From update of attachment 98515 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=98515&action=review
> 
> > Source/WebCore/platform/graphics/mac/MediaPlayerPrivateQTKit.mm:246
> > +    // Check to see if QTKit >= 7.6.3 is installed, which defines NoRemoteToLocal and NoLocalToRemote.
> > +    // If not, just set NoCrossSite = YES, which does the same thing as NoRemoteToLocal = YES and 
> > +    // NoLocalToRemote = YES in QTKit < 7.6.3.
> 
> We don't actually check the QTKit version here, so it would probably be better to say something like "... see if the current version of QTKit has NoRemoteToLocal ..." instead.

How about: "Check to see if QTSecurityPolicyNoRemoteToLocalSiteAttribute is defined, which was added in QTKit 7.6.3."

I thought it was important to mention that "NoCrossSite" does the right thing in versions of QTKit previous to 7.6.3.

[Eric Carlson]

(In reply to comment #6)
> 
> How about: "Check to see if QTSecurityPolicyNoRemoteToLocalSiteAttribute is defined, which was added in QTKit 7.6.3."
> 
> I thought it was important to mention that "NoCrossSite" does the right thing in versions of QTKit previous to 7.6.3.

That sounds fine.

[Jer Noble]

Committed r89718: <http://trac.webkit.org/changeset/89718>