Bug 63323 - Make <video> app cache test exit immediately on failure
Summary: Make <video> app cache test exit immediately on failure
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-24 07:50 PDT by Eric Carlson
Modified: 2011-06-24 09:01 PDT (History)
1 user (show)

See Also:

Attachments
Proposed patch. (2.58 KB, patch)
2011-06-24 08:10 PDT, Eric Carlson 		ap: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2011-06-24 07:50:51 PDT 
One of the conditions tested by http/tests/appcache/video.html is setting the video element's src to a JavaScript file included in the manifest to test the handling of a non-media resource from the manifest. This is the last condition tested so the test ends when an 'error' event is be posted, but if the media engine loads the JavaScript file "successfully" the test enters an infinite loop continues until the DRT watchdog timer kills it.
Comment 1 Eric Carlson 2011-06-24 08:10:12 PDT 
Created attachment 98493 [details]
Proposed patch.
Comment 2 Alexey Proskuryakov 2011-06-24 08:50:28 PDT 
Comment on attachment 98493 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=98493&action=review

> LayoutTests/http/tests/appcache/video.html:46
> +                        failTest("<br>Loaded file JavaScript file as media!");

Extra "file" here.
Comment 3 Eric Carlson 2011-06-24 09:01:31 PDT 
http://trac.webkit.org/changeset/89676