Bug 63321 – [WK2] fast/frames/iframe-plugin-load-remove-document-crash.html crashes

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Csaba Osztrogonác]

stderr: Xlib:  extension "RANDR" missing on display ":7.0".

[Csaba Osztrogonác]

Skipped by http://trac.webkit.org/changeset/89672

[Balazs Kelemen]

Remove [Qt] since it seems to  be a common bug that somehow only appears on Qt.

[Balazs Kelemen]

Created attachment 98706 [details]
Patch

[Balazs Kelemen]

I am still trying to find out why it is only appearing on Qt.

[Balazs Kelemen]

The null check is consistent with WebKit1:
void PluginView::didFail(const ResourceError& error)
{
    if (m_status != PluginStatusLoadedSuccessfully)
        return;

    ASSERT(m_loadManually);
    
    if (m_manualStream) <- !!!
        m_manualStream->didFail(0, error);
}

[Balazs Kelemen]

ping

[Simon Hausmann]

Comment on attachment 98706 [details]
Patch

r=me. I guess the test only fails in debug builds? (which is why we don't see it on the bots and this patch doesn't affect the skiplist?)

[Simon Hausmann]

(In reply to comment #7)
> (From update of attachment 98706 [details])
> r=me. I guess the test only fails in debug builds? (which is why we don't see it on the bots and this patch doesn't affect the skiplist?)

Ohh, it looks like Ossy skipped it in http://trac.webkit.org/changeset/89672 . Please land this patch together with unskip.

[Balazs Kelemen]

Committed r101232: <http://trac.webkit.org/changeset/101232>