Bug 63304 - Limit WebGL internal drawingBuffer size to 4k x 4k
Summary: Limit WebGL internal drawingBuffer size to 4k x 4k
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Zhenyao Mo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-23 17:51 PDT by Zhenyao Mo
Modified: 2011-06-23 18:53 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.48 KB, patch)
2011-06-23 18:05 PDT, Zhenyao Mo
kbr: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zhenyao Mo 2011-06-23 17:51:02 PDT
Tested with 8k x 8k, it exhausted memory and causes a lot of un-expected issues.

According to WebGL spec, internal drawingBuffer size is allowed to be smaller than canvas size.  Thus, limiting it to 4k x 4k.
Comment 1 Zhenyao Mo 2011-06-23 18:05:25 PDT
Created attachment 98446 [details]
Patch
Comment 2 Kenneth Russell 2011-06-23 18:10:46 PDT
Comment on attachment 98446 [details]
Patch

OK. I'm sure we're going to have to revisit this in the future for mobile devices.
Comment 3 Zhenyao Mo 2011-06-23 18:53:50 PDT
Committed r89650: <http://trac.webkit.org/changeset/89650>