Bug 63293 – convert editing/deleting/5390681-2.html to dump-as-markup

• Status: RESOLVED
• Resolution: FIXED
• Component: HTML Editing

[Wyatt Carss]

convert editing/deleting/5390681-2.html to dump-as-markup

[Wyatt Carss]

Created attachment 98410 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 98410 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98410&action=review

> LayoutTests/ChangeLog:14
> +        * editing/deleting/5390681-2.html:
> +        * editing/deleting/5390681.html:

Please rename these files.

> LayoutTests/editing/deleting/5390681-2.html:4
> +<p id="description">This tests for a bug where expansion for smart delete would not consider editable boundaries.  Only 'foo' should be deleted.  You should see ' bar'. <b>There is a bug: while the non-editable space isn't deleted, deletion inserts a placeholder when it shouldn't.</b></p>

Clearly, we're not inserting a placeholder anymore.  We should probably remove that sentence.  r- due to this description.

[Wyatt Carss]

Created attachment 98427 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 98427 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98427&action=review

> LayoutTests/editing/deleting/smart-delete-across-editable-boundaries-2.html:4
> +<p id="description">This tests for a bug where expansion for smart delete would not consider editable boundaries. Only 'foo' should be deleted. You should see ' bar'. radr id: 5390681</p>

You should use the format <rdar://problem/5390681>.

> LayoutTests/editing/deleting/smart-delete-across-editable-boundaries.html:12
> +Markup.description("This tests for a bug where expansion for smart delete would not consider editable boundaries. Only 'foo' should be deleted. You should see ' bar'. radr id: 5390681");

Ditto about the rdar id.

[Wyatt Carss]

Created attachment 98451 [details]
Patch

[Eric Seidel (no email)]

Comment on attachment 98451 [details]
Patch

LGTM.

[WebKit Review Bot]

Comment on attachment 98451 [details]
Patch

Clearing flags on attachment: 98451

Committed r95003: <http://trac.webkit.org/changeset/95003>

[WebKit Review Bot]

All reviewed patches have been landed.  Closing bug.