Bug 63293 - convert editing/deleting/5390681-2.html to dump-as-markup
Summary: convert editing/deleting/5390681-2.html to dump-as-markup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Enhancement
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-23 14:46 PDT by Wyatt Carss
Modified: 2011-09-12 20:12 PDT (History)
6 users (show)

See Also:


Attachments
Patch (93.94 KB, patch)
2011-06-23 14:48 PDT, Wyatt Carss
no flags Details | Formatted Diff | Diff
Patch (16.99 KB, patch)
2011-06-23 16:11 PDT, Wyatt Carss
no flags Details | Formatted Diff | Diff
Patch (17.38 KB, patch)
2011-06-23 18:50 PDT, Wyatt Carss
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wyatt Carss 2011-06-23 14:46:43 PDT
convert editing/deleting/5390681-2.html to dump-as-markup
Comment 1 Wyatt Carss 2011-06-23 14:48:42 PDT
Created attachment 98410 [details]
Patch
Comment 2 Ryosuke Niwa 2011-06-23 14:54:54 PDT
Comment on attachment 98410 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98410&action=review

> LayoutTests/ChangeLog:14
> +        * editing/deleting/5390681-2.html:
> +        * editing/deleting/5390681.html:

Please rename these files.

> LayoutTests/editing/deleting/5390681-2.html:4
> +<p id="description">This tests for a bug where expansion for smart delete would not consider editable boundaries.  Only 'foo' should be deleted.  You should see ' bar'. <b>There is a bug: while the non-editable space isn't deleted, deletion inserts a placeholder when it shouldn't.</b></p>

Clearly, we're not inserting a placeholder anymore.  We should probably remove that sentence.  r- due to this description.
Comment 3 Wyatt Carss 2011-06-23 16:11:06 PDT
Created attachment 98427 [details]
Patch
Comment 4 Ryosuke Niwa 2011-06-23 16:55:19 PDT
Comment on attachment 98427 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98427&action=review

> LayoutTests/editing/deleting/smart-delete-across-editable-boundaries-2.html:4
> +<p id="description">This tests for a bug where expansion for smart delete would not consider editable boundaries. Only 'foo' should be deleted. You should see ' bar'. radr id: 5390681</p>

You should use the format <rdar://problem/5390681>.

> LayoutTests/editing/deleting/smart-delete-across-editable-boundaries.html:12
> +Markup.description("This tests for a bug where expansion for smart delete would not consider editable boundaries. Only 'foo' should be deleted. You should see ' bar'. radr id: 5390681");

Ditto about the rdar id.
Comment 5 Wyatt Carss 2011-06-23 18:50:40 PDT
Created attachment 98451 [details]
Patch
Comment 6 Eric Seidel (no email) 2011-09-12 15:48:31 PDT
Comment on attachment 98451 [details]
Patch

LGTM.
Comment 7 WebKit Review Bot 2011-09-12 20:12:42 PDT
Comment on attachment 98451 [details]
Patch

Clearing flags on attachment: 98451

Committed r95003: <http://trac.webkit.org/changeset/95003>
Comment 8 WebKit Review Bot 2011-09-12 20:12:46 PDT
All reviewed patches have been landed.  Closing bug.