Bug 63287 - [GTK] [WebKit2] WebKitTestRunner does not properly load TestNetscapePlugin
Summary: [GTK] [WebKit2] WebKitTestRunner does not properly load TestNetscapePlugin
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Martin Robinson
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2011-06-23 14:02 PDT by Martin Robinson
Modified: 2011-06-23 14:41 PDT (History)
0 users

See Also:

Attachments
Patch (3.67 KB, patch)
2011-06-23 14:30 PDT, Martin Robinson 		xan.lopez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2011-06-23 14:02:28 PDT 
TestNetscapePlugin is not loaded for WKTR runs.
Comment 1 Martin Robinson 2011-06-23 14:30:43 PDT 
Created attachment 98405 [details]
Patch
Comment 2 Xan Lopez 2011-06-23 14:34:54 PDT 
Comment on attachment 98405 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98405&action=review

> Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp:79
> +    return g_filename_to_utf8(value, -1, 0, &bytesWritten, 0);

Should just pass 0 for bitesWritten?
Comment 3 Martin Robinson 2011-06-23 14:40:13 PDT 
Comment on attachment 98405 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98405&action=review

Thanks for the review!

>> Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp:79
>> +    return g_filename_to_utf8(value, -1, 0, &bytesWritten, 0);
> 
> Should just pass 0 for bitesWritten?

The documentation doesn't say you can, so I think it's safer to leave it. :/
Comment 4 Martin Robinson 2011-06-23 14:41:48 PDT 
Committed r89616: <http://trac.webkit.org/changeset/89616>