Bug 63260 - [chromium] Fix WebScrollBarImpl on Mac after recent smooth scrolling changes
Summary: [chromium] Fix WebScrollBarImpl on Mac after recent smooth scrolling changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: John Abd-El-Malek
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-23 09:40 PDT by John Abd-El-Malek
Modified: 2011-06-23 10:36 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.58 KB, patch)
2011-06-23 09:50 PDT, John Abd-El-Malek 		tony: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Abd-El-Malek 2011-06-23 09:40:05 PDT 
[chromium] Fix WebScrollBarImpl on Mac after recent smooth scrolling changes
Comment 1 John Abd-El-Malek 2011-06-23 09:50:28 PDT 
Created attachment 98360 [details]
Patch
Comment 2 John Abd-El-Malek 2011-06-23 10:01:27 PDT 
Sailesh/Scott: can one of you look at this to see if it's reasonable? Tony can then approve.

Background: the chrome pdf plugin reuses WebKit scrollbars through the WebScrollbar API. Sometime in the last few weeks, it stopped working on Mac. It looks to me like it's related to the smooth scrolling code, since methods on ScrollableArea that weren't used before started being called.

This is tested in Chrome, but unfortunately there was another problem with the mac bots that run these tests so that they were red before this regressed. I'm following up on getting those green again.
Comment 3 Sailesh Agrawal 2011-06-23 10:25:13 PDT 
Looks good to me. It might be good to replace references to smooth scrolling with "ScrollAnimator". Currently we use the scroll animator with smooth scrolling disabled.
Comment 4 John Abd-El-Malek 2011-06-23 10:35:35 PDT 
done. thanks for the quick lookover.  i will merge this to m13 branch as well.
Comment 5 John Abd-El-Malek 2011-06-23 10:36:18 PDT 
Committed r89584: <http://trac.webkit.org/changeset/89584>

(webkit-patch land crashed)