notImplemented();
Created attachment 98341 [details] Patch
Running run-webkit-tests --debug -2 LayoutTests/plugins/mouse-events.html produces the correct output sometimes for me, but just as often does not. Either my setup or WebKitTestRunner is unreliable for this test. First time I've tried to do a WebKit2 change, perhaps what I'm seeing is normal. I need to dismantle my VS2005 setup and move to VS2008/10 for work reasons anyway, and so I'll be unable to test this change once that's done.
Created attachment 100089 [details] Patch Update after http://trac.webkit.org/changeset/90327
Comment on attachment 100089 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100089&action=review > Source/WebKit2/ChangeLog:10 > +2011-07-08 Noel Gordon <noel.gordon@gmail.com> > + > + Reviewed by NOBODY (OOPS!). > + > + [WebKit2] Forward focus events to windowless plugins on the windows port. > + https://bugs.webkit.org/show_bug.cgi?id=63251 > + > + * WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp: > + (WebKit::NetscapePlugin::platformSetFocus): > + Please mention what test(s) this is covered by, for posterity's sake. > Source/WebKit2/WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:316 > CurrentPluginSetter setCurrentPlugin(this); > > - notImplemented(); > + if (m_isWindowed) > + return; Maybe we should put the early return above the CurrentPluginSetter?
Comment on attachment 100089 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100089&action=review >> Source/WebKit2/WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:316 >> + return; > > Maybe we should put the early return above the CurrentPluginSetter? I guess there's existing code that does it the way you did.
> Please mention what test(s) this is covered by, for posterity's sake. Done.
> >> Source/WebKit2/WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:316 > >> + return; > > > > Maybe we should put the early return above the CurrentPluginSetter? > > I guess there's existing code that does it the way you did. Yes, I just followed the existing code.
Created attachment 100190 [details] Patch
Comment on attachment 100190 [details] Patch Clearing flags on attachment: 100190 Committed r90686: <http://trac.webkit.org/changeset/90686>
All reviewed patches have been landed. Closing bug.