RESOLVED FIXED 63251
[WebKit2] Forward focus events to windowless plugins on the windows port.
https://bugs.webkit.org/show_bug.cgi?id=63251
Summary [WebKit2] Forward focus events to windowless plugins on the windows port.
noel gordon
Reported 2011-06-23 06:19:48 PDT
notImplemented();
Attachments
Patch (1.56 KB, patch)
2011-06-23 06:26 PDT, noel gordon
no flags
Patch (1.54 KB, patch)
2011-07-08 01:10 PDT, noel gordon
aroben: review+
aroben: commit-queue-
Patch (1.68 KB, patch)
2011-07-08 17:41 PDT, noel gordon
no flags
noel gordon
Comment 1 2011-06-23 06:26:18 PDT
noel gordon
Comment 2 2011-06-23 06:44:25 PDT
Running run-webkit-tests --debug -2 LayoutTests/plugins/mouse-events.html produces the correct output sometimes for me, but just as often does not. Either my setup or WebKitTestRunner is unreliable for this test. First time I've tried to do a WebKit2 change, perhaps what I'm seeing is normal. I need to dismantle my VS2005 setup and move to VS2008/10 for work reasons anyway, and so I'll be unable to test this change once that's done.
noel gordon
Comment 3 2011-07-08 01:10:08 PDT
Adam Roben (:aroben)
Comment 4 2011-07-08 12:56:50 PDT
Comment on attachment 100089 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100089&action=review > Source/WebKit2/ChangeLog:10 > +2011-07-08 Noel Gordon <noel.gordon@gmail.com> > + > + Reviewed by NOBODY (OOPS!). > + > + [WebKit2] Forward focus events to windowless plugins on the windows port. > + https://bugs.webkit.org/show_bug.cgi?id=63251 > + > + * WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp: > + (WebKit::NetscapePlugin::platformSetFocus): > + Please mention what test(s) this is covered by, for posterity's sake. > Source/WebKit2/WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:316 > CurrentPluginSetter setCurrentPlugin(this); > > - notImplemented(); > + if (m_isWindowed) > + return; Maybe we should put the early return above the CurrentPluginSetter?
Adam Roben (:aroben)
Comment 5 2011-07-08 12:57:34 PDT
Comment on attachment 100089 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100089&action=review >> Source/WebKit2/WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:316 >> + return; > > Maybe we should put the early return above the CurrentPluginSetter? I guess there's existing code that does it the way you did.
noel gordon
Comment 6 2011-07-08 17:37:27 PDT
> Please mention what test(s) this is covered by, for posterity's sake. Done.
noel gordon
Comment 7 2011-07-08 17:40:43 PDT
> >> Source/WebKit2/WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:316 > >> + return; > > > > Maybe we should put the early return above the CurrentPluginSetter? > > I guess there's existing code that does it the way you did. Yes, I just followed the existing code.
noel gordon
Comment 8 2011-07-08 17:41:34 PDT
WebKit Review Bot
Comment 9 2011-07-09 12:47:22 PDT
Comment on attachment 100190 [details] Patch Clearing flags on attachment: 100190 Committed r90686: <http://trac.webkit.org/changeset/90686>
WebKit Review Bot
Comment 10 2011-07-09 12:47:29 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.