Bug 63250 - Web Inspector: [Chromium] Fix showing dominator leaf nodes after r89457
: Web Inspector: [Chromium] Fix showing dominator leaf nodes after r89457
Status: RESOLVED FIXED
: WebKit
Web Inspector (Deprecated)
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To:
:
:
:
:
  Show dependency treegraph
 
Reported: 2011-06-23 05:40 PST by
Modified: 2011-06-23 05:52 PST (History)


Attachments
patch (2.78 KB, patch)
2011-06-23 05:42 PST, Mikhail Naganov
yurys: review+
mnaganov: commit‑queue-
Review Patch | Details | Formatted Diff | Diff


Note

You need to log in before you can comment on or make changes to this bug.


Description From 2011-06-23 05:40:29 PST
I forgot to update WebInspector.HeapSnapshotFilteredOrderedIterator.isEmpty. This results in showing leaf nodes as if they have children.
------- Comment #1 From 2011-06-23 05:42:26 PST -------
Created an attachment (id=98338) [details]
patch
------- Comment #2 From 2011-06-23 05:52:11 PST -------
Manually committed http://trac.webkit.org/changeset/89562

2011-06-23  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [Chromium] Fix showing dominator leaf nodes after r89457
        https://bugs.webkit.org/show_bug.cgi?id=63250

        * inspector/front-end/DetailedHeapshotView.js:
        * inspector/front-end/HeapSnapshot.js:
        (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.get isEmpty):