Bug 63250 - Web Inspector: [Chromium] Fix showing dominator leaf nodes after r89457
: Web Inspector: [Chromium] Fix showing dominator leaf nodes after r89457
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated)
: 528+ (Nightly build)
: All All
: P2 Normal
Assigned To: Mikhail Naganov
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-23 05:40 PDT by Mikhail Naganov
Modified: 2011-06-23 05:52 PDT (History)
10 users (show)

See Also:


Attachments
patch (2.78 KB, patch)
2011-06-23 05:42 PDT, Mikhail Naganov
yurys: review+
mnaganov: commit‑queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mikhail Naganov 2011-06-23 05:40:29 PDT
I forgot to update WebInspector.HeapSnapshotFilteredOrderedIterator.isEmpty. This results in showing leaf nodes as if they have children.
Comment 1 Mikhail Naganov 2011-06-23 05:42:26 PDT
Created attachment 98338 [details]
patch
Comment 2 Mikhail Naganov 2011-06-23 05:52:11 PDT
Manually committed http://trac.webkit.org/changeset/89562

2011-06-23  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [Chromium] Fix showing dominator leaf nodes after r89457
        https://bugs.webkit.org/show_bug.cgi?id=63250

        * inspector/front-end/DetailedHeapshotView.js:
        * inspector/front-end/HeapSnapshot.js:
        (WebInspector.HeapSnapshotFilteredOrderedIterator.prototype.get isEmpty):