Bug 63249 – [UNIX] Fix compile warnings in NetscapePluginX11.cpp

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Carlos Garcia Campos]

../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: In function ‘void WebKit::setXButtonEventFields(XEvent&, const WebKit::WebMouseEvent&, const WebCore::IntPoint&)’:
../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:405:12: warning: enumeration value ‘NoButton’ not handled in switch
../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: In member function ‘bool WebKit::NetscapePlugin::platformHandleMouseEvent(const WebKit::WebMouseEvent&)’:
../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:457:12: warning: enumeration value ‘NoType’ not handled in switch
../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:457:12: warning: enumeration value ‘Wheel’ not handled in switch
../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:457:12: warning: enumeration value ‘KeyDown’ not handled in switch
../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:457:12: warning: enumeration value ‘KeyUp’ not handled in switch
../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:457:12: warning: enumeration value ‘RawKeyDown’ not handled in switch
../Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:457:12: warning: enumeration value ‘Char’ not handled in switch

[Carlos Garcia Campos]

Created attachment 98337 [details]
Patch

[Martin Robinson]

Comment on attachment 98337 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=98337&action=review

Looks good, but I have a few minor requests before landing.

> Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:362
> +    case WebMouseEvent::LeftButton:
> +    default:
> +        xButton.button = Button1;
> +        break;

If we are receiving other types of events shouldn't we be passing them properly to the plugin. I think it's more correct to simply have ASSERT_NOT_REACHED() for default:. This makes me wonder whether wheel events are supported or not.

> Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:414
> +    default:
> +        return false;

I would rather you list them explicitly here. Do you mind changing that before landing?

[Carlos Garcia Campos]

(In reply to comment #2)
> (From update of attachment 98337 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=98337&action=review
> 
> Looks good, but I have a few minor requests before landing.
> 
> > Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:362
> > +    case WebMouseEvent::LeftButton:
> > +    default:
> > +        xButton.button = Button1;
> > +        break;
> 
> If we are receiving other types of events shouldn't we be passing them properly to the plugin. I think it's more correct to simply have ASSERT_NOT_REACHED() for default:. This makes me wonder whether wheel events are supported or not.

Since this code is shared between Gtk and Qt ports I looked at current WebKi1 code of both ports and followed it. There's another method for wheel events platformHandleWheelEvent().

> > Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:414
> > +    default:
> > +        return false;
> 
> I would rather you list them explicitly here. Do you mind changing that before landing?

Sure. Thanks for reviewing.

[Carlos Garcia Campos]

Committed r89580: <http://trac.webkit.org/changeset/89580>