Bug 63237 - [Qt] Fix tst_QWebFrame::setUrlWithPendingLoads() API test
Summary: [Qt] Fix tst_QWebFrame::setUrlWithPendingLoads() API test
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 38654
  Show dependency tree / graph
 
Reported: 2011-06-23 01:56 PDT by Csaba Osztrogonác
Modified: 2012-11-14 05:29 PST (History)
4 users (show)

See Also:

Attachments
Patch (1.90 KB, patch)
2012-11-14 04:42 PST, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2011-06-23 01:56:27 PDT 
http://build.webkit.org/builders/Qt%20Linux%20Release/builds/34519

FAIL!  : tst_QWebFrame::setUrlWithPendingLoads() Received a fatal error.
   Loc: [Unknown file(0)]
Comment 1 Csaba Osztrogonác 2011-06-23 05:51:50 PDT 
Marked as expected fails: http://trac.webkit.org/changeset/89561
Comment 2 Aparna Nandyal 2011-07-21 11:42:12 PDT 
Cause for this failure:
1. setHtml is done first and this  makes request to cache loader to load the image. This in turn makes an asynchronous request and even before the asynchronous call is completed setUrl is called.
2. setUrl does not cancel the previous request before loading the new url. Hence the problem. 

Would it be acceptable to cancel the request before actually going on to clear the frame like:

void QWebFrame::setUrl(const QUrl &url)
{
    d->frame->loader()->stopForUserCancel();
    clearCoreFrame(d->frame);
    ...

}

Alternately the test case would pass if we add waitForSignal between the setHtml and setUrl calls.
Comment 3 Csaba Osztrogonác 2012-11-14 04:42:22 PST 
Created attachment 174131 [details]
Patch
Comment 4 Csaba Osztrogonác 2012-11-14 05:29:50 PST 
Comment on attachment 174131 [details]
Patch

Clearing flags on attachment: 174131

Committed r134596: <http://trac.webkit.org/changeset/134596>
Comment 5 Csaba Osztrogonác 2012-11-14 05:29:56 PST 
All reviewed patches have been landed.  Closing bug.