Bug 63221 - sheriffbot can no longer restart
Summary: sheriffbot can no longer restart
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Adam Barth
Depends on:
Reported: 2011-06-22 19:27 PDT by WebKit Review Bot
Modified: 2011-06-23 14:43 PDT (History)
2 users (show)

See Also:

Patch (5.08 KB, patch)
2011-06-23 11:56 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Review Bot 2011-06-22 19:27:23 PDT
sheriffbot can no longer restart
Requested by abarth on #webkit.
Comment 1 Adam Barth 2011-06-22 19:28:01 PDT
Eric broke this when catching Exception.  We use exceptions to terminate!
Comment 2 Eric Seidel (no email) 2011-06-22 19:51:37 PDT
Since when do good designs use exceptions for normal control flow? :p.  Besides, the unit tests pass. :)
Comment 3 Adam Barth 2011-06-22 20:18:05 PDT
You're welcome to change the design when you fix the bug.  :)
Comment 4 Eric Seidel (no email) 2011-06-23 11:56:57 PDT
Created attachment 98376 [details]
Comment 5 Adam Barth 2011-06-23 13:58:57 PDT
Comment on attachment 98376 [details]

Nice.  I didn't know that about SystemExit.
Comment 6 WebKit Review Bot 2011-06-23 14:42:10 PDT
The commit-queue encountered the following flaky tests while processing attachment 98376 [details]:

fast/filesystem/file-writer-truncate-extend.html bug 63292 (author: ericu@chromium.org)
The commit-queue is continuing to process your patch.
Comment 7 WebKit Review Bot 2011-06-23 14:43:50 PDT
Comment on attachment 98376 [details]

Clearing flags on attachment: 98376

Committed r89618: <http://trac.webkit.org/changeset/89618>
Comment 8 WebKit Review Bot 2011-06-23 14:43:55 PDT
All reviewed patches have been landed.  Closing bug.