Bug 63218 - DFG JIT - remove machine type guarantees from graph
Summary: DFG JIT - remove machine type guarantees from graph
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-22 18:51 PDT by Gavin Barraclough
Modified: 2011-06-23 14:04 PDT (History)
0 users

See Also:

Attachments
The patch (31.31 KB, patch)
2011-06-22 18:53 PDT, Gavin Barraclough 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2011-06-22 18:51:19 PDT 
The DFG JIT currently makes assumptions about the types of machine registers that certain nodes will be loaded into.  This will be broken as we generate nodes to produce both integer and double code paths.  Remove int<->double conversions nodes.  This design decision also gave rise to multiple types of constant nodes, requiring separate handling for each type.  Merge these back into JSConstant.
Comment 1 Gavin Barraclough 2011-06-22 18:53:44 PDT 
Created attachment 98292 [details]
The patch
Comment 2 Gavin Barraclough 2011-06-23 14:04:53 PDT 
Fixed in r89611