Bug 63211 - Make sheriff-bot robust against exceptions from commands
Summary: Make sheriff-bot robust against exceptions from commands
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-22 18:17 PDT by Eric Seidel (no email)
Modified: 2011-06-22 18:44 PDT (History)
3 users (show)

See Also:

Attachments
Patch (4.64 KB, patch)
2011-06-22 18:18 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2011-06-22 18:17:33 PDT 
Make sheriff-bot robust against exceptions from commands
Comment 1 Eric Seidel (no email) 2011-06-22 18:18:08 PDT 
Created attachment 98282 [details]
Patch
Comment 2 Adam Barth 2011-06-22 18:21:27 PDT 
Comment on attachment 98282 [details]
Patch

Looks great.  Catching Exception is always scary, but this is probably the right thing to do.
Comment 3 WebKit Review Bot 2011-06-22 18:44:33 PDT 
Comment on attachment 98282 [details]
Patch

Clearing flags on attachment: 98282

Committed r89518: <http://trac.webkit.org/changeset/89518>
Comment 4 WebKit Review Bot 2011-06-22 18:44:37 PDT 
All reviewed patches have been landed.  Closing bug.